Skip to content

Commit c802f16

Browse files
ShichaoQiuShichao Qiu
andauthored
[Containerapp] az containerapp sessionpool create: Add Shell container type (#9361)
* Update parameters * update history * add help infos * update test * fix comment * remove shell support * update test file * Revert "remove shell support" This reverts commit 7766ea8. * remove GPU support * update test file * fix test issue --------- Co-authored-by: Shichao Qiu <[email protected]>
1 parent f9a5dc3 commit c802f16

File tree

6 files changed

+20697
-19894
lines changed

6 files changed

+20697
-19894
lines changed

src/containerapp/HISTORY.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ Release History
55
upcoming
66
++++++
77
* 'az containerapp env premium-ingress add/update': remove `--min-replicas` and `--max-replicas`
8+
* 'az containerapp sessionpool create': Add `Shell` container type
89

910
1.2.0b4
1011
++++++

src/containerapp/azext_containerapp/_help.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1967,6 +1967,10 @@
19671967
text: |
19681968
az containerapp sessionpool create -n mysessionpool -g MyResourceGroup \\
19691969
--location eastasia
1970+
- name: Create or update a Session Pool with container type Shell default settings.
1971+
text: |
1972+
az containerapp sessionpool create -n mysessionpool -g MyResourceGroup \\
1973+
--container-type Shell --location westus3
19701974
- name: Create or update a Session Pool with container type PythonLTS, with max concurrent sessions is 30, ready session instances 20.
19711975
text: |
19721976
az containerapp sessionpool create -n mysessionpool -g MyResourceGroup \\

src/containerapp/azext_containerapp/_params.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@ def load_arguments(self, _):
451451
c.argument('network_status', arg_type=get_enum_type(["EgressEnabled", "EgressDisabled"]), help="Egress is enabled for the Sessions or not.")
452452

453453
with self.argument_context('containerapp sessionpool create', arg_group='Configuration') as c:
454-
c.argument('container_type', arg_type=get_enum_type(["CustomContainer", "PythonLTS", "NodeLTS"]), help="The pool type of the Session Pool, default='PythonLTS'")
454+
c.argument('container_type', arg_type=get_enum_type(["CustomContainer", "PythonLTS", "NodeLTS", "Shell"]), help="The pool type of the Session Pool, default='PythonLTS'")
455455
c.argument('lifecycle_type', arg_type=get_enum_type(["Timed", "OnContainerExit"]), help="The lifecycle type of the Session Pool", default='Timed')
456456

457457
with self.argument_context('containerapp sessionpool update', arg_group='Configuration') as c:

0 commit comments

Comments
 (0)