Merge pull request #19 from khushishah513/function-comments

resolving some of the comments on PR

Author: khushishah513

src/containerapp/HISTORY.rst

@@ -4,16 +4,16 @@ Release History
 ===============
 upcoming
 ++++++
-
-1.2.0b4
-++++++
 * 'az containerapp function list': List functions in a container app
 * 'az containerapp function show': Show specific function in a container app
 * 'az containerapp function keys show': Show specific function key in a container app
 * 'az containerapp function keys list': List function keys in a container app
 * 'az containerapp function keys set': Create a new or update an existing function key in a container app
 * 'az containerapp function invocations summary': Get function invocation summary from Application Insights
 * 'az containerapp function invocations traces': Get function invocation traces from Application Insights
+
+1.2.0b4
+++++++
 * 'az containerapp update/up': Disallow changing `--revisions-mode` to Labels.
 * 'az containerapp session code-interpreter': Fix `--path` in examples
 * 'az containerapp sessionpool create/update': Support `--lifecycle-type` and `--max-alive-period`

src/containerapp/azext_containerapp/custom.py

@@ -3615,6 +3615,7 @@ def list_maintenance_config(cmd, resource_group_name, env_name):
 
 
 def containerapp_debug(cmd, resource_group_name, name, container=None, revision=None, replica=None, debug_command=None):
+    logger.warning("Connecting...")
     if debug_command is not None:
         raw_parameters = {
             'resource_group_name': resource_group_name,
@@ -3654,12 +3655,14 @@ def containerapp_debug(cmd, resource_group_name, name, container=None, revision=
 
     while conn.is_connected:
         if not reader.is_alive() or not writer.is_alive():
+            logger.warning("Reader or Writer for WebSocket is not alive. Closing the connection.")
             conn.disconnect()
 
         try:
             time.sleep(0.1)
         except KeyboardInterrupt:
             if conn.is_connected:
+                logger.info("Caught KeyboardInterrupt. Sending ctrl+c to server")
                 conn.send(SSH_CTRL_C_MSG)
 
 

src/containerapp/azext_containerapp/tests/latest/test_containerapp_function.py

@@ -34,7 +34,7 @@ def __init__(self, *arg, **kwargs):
     @ResourceGroupPreparer(location="northcentralus")
     def test_containerapp_function_list_show_basic(self, resource_group):
         """Test basic function list functionality with various scenarios"""
-        location = "northcentralusstage"
+        location = TEST_LOCATION
         self.cmd('configure --defaults location={}'.format(location))
 
         ca_name = self.create_random_name(prefix='containerapp', length=24)
@@ -365,7 +365,7 @@ def test_containerapp_function_keys(self, resource_group):
     @ResourceGroupPreparer(location="northcentralus")
     def test_containerapp_function_invocations_summary_traces(self, resource_group):
         """Test function keys show/list/set functionality using connection string and App Insights"""
-        location = "northcentralus"
+        location = TEST_LOCATION
         functionapp_location = "northcentralusstage"  
         funcapp_name = self.create_random_name("functionapp", length=24)
         image = "mcr.microsoft.com/azure-functions/dotnet8-quickstart-demo:1.0"