Skip to content

Commit ca0a1b1

Browse files
author
juanbe
committed
skip none overrides on localdns profile
1 parent e0c6357 commit ca0a1b1

File tree

1 file changed

+16
-8
lines changed

1 file changed

+16
-8
lines changed

src/aks-preview/azext_aks_preview/agentpool_decorator.py

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1478,12 +1478,16 @@ def build_override(override_dict):
14781478

14791479
# Build kubeDNSOverrides and vnetDNSOverrides from the localdns_profile
14801480
kube_overrides = localdns_profile.get("kubeDNSOverrides")
1481-
for key, value in kube_overrides.items():
1482-
kube_dns_overrides[key] = build_override(value)
1481+
if kube_overrides is not None:
1482+
for key, value in kube_overrides.items():
1483+
if value is not None:
1484+
kube_dns_overrides[key] = build_override(value)
14831485

14841486
vnet_overrides = localdns_profile.get("vnetDNSOverrides")
1485-
for key, value in vnet_overrides.items():
1486-
vnet_dns_overrides[key] = build_override(value)
1487+
if vnet_overrides is not None:
1488+
for key, value in vnet_overrides.items():
1489+
if value is not None:
1490+
vnet_dns_overrides[key] = build_override(value)
14871491

14881492
agentpool.local_dns_profile = self.models.LocalDNSProfile(
14891493
mode=localdns_profile.get("mode"),
@@ -1817,12 +1821,16 @@ def build_override(override_dict):
18171821

18181822
# Build kubeDNSOverrides and vnetDNSOverrides from the localdns_profile
18191823
kube_overrides = localdns_profile.get("kubeDNSOverrides")
1820-
for key, value in kube_overrides.items():
1821-
kube_dns_overrides[key] = build_override(value)
1824+
if kube_overrides is not None:
1825+
for key, value in kube_overrides.items():
1826+
if value is not None:
1827+
kube_dns_overrides[key] = build_override(value)
18221828

18231829
vnet_overrides = localdns_profile.get("vnetDNSOverrides")
1824-
for key, value in vnet_overrides.items():
1825-
vnet_dns_overrides[key] = build_override(value)
1830+
if vnet_overrides is not None:
1831+
for key, value in vnet_overrides.items():
1832+
if value is not None:
1833+
vnet_dns_overrides[key] = build_override(value)
18261834

18271835
agentpool.local_dns_profile = self.models.LocalDNSProfile(
18281836
mode=localdns_profile.get("mode"),

0 commit comments

Comments
 (0)