Skip to content

Commit e0df94c

Browse files
committed
Rename commands
1 parent a765883 commit e0df94c

File tree

7 files changed

+10469
-42
lines changed

7 files changed

+10469
-42
lines changed

src/containerapp/HISTORY.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Release History
44
===============
55
upcoming
66
++++++
7-
* 'az containerapp env ingress': New environment level ingress configuration.
7+
* 'az containerapp env premium-ingress': New environment level ingress configuration.
88
* 'az containerapp auth update': Support authenticating blob storage token store using managed identity with `--blob-container-uri` and `--blob-container-identity`.
99

1010
1.1.0b4

src/containerapp/azext_containerapp/_help.py

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -2364,51 +2364,51 @@
23642364
az containerapp env http-route-config delete -g MyResourceGroup -n MyEnvironment -r configname
23652365
"""
23662366

2367-
helps['containerapp env ingress show'] = """
2367+
helps['containerapp env premium-ingress show'] = """
23682368
type: command
2369-
short-summary: Show the ingress settings for the environment.
2369+
short-summary: Show the premium ingress settings for the environment.
23702370
examples:
2371-
- name: Show the ingress settings for the environment.
2371+
- name: Show the premium ingress settings for the environment.
23722372
text: |
2373-
az containerapp env ingress show -g MyResourceGroup -n MyEnvironment
2373+
az containerapp env premium-ingress show -g MyResourceGroup -n MyEnvironment
23742374
"""
23752375

2376-
helps['containerapp env ingress'] = """
2376+
helps['containerapp env premium-ingress'] = """
23772377
type: group
23782378
short-summary: Configures premium ingress settings for the environment.
23792379
long-summary: |
23802380
Premium ingress settings apply to all applications in the environment. They allow moving the ingress instances to a workload profile and scaling them beyond the system defaults to enable high traffic workloads. Other settings include request idle timeouts, header count limits, and the termination grace period.
23812381
examples:
2382-
- name: Set the ingress settings for the environment.
2382+
- name: Enable premium ingress for the environment.
23832383
text: |
2384-
az containerapp env ingress set -g MyResourceGroup -n MyEnvironment -w WorkloadProfileName --min-replicas 2 --max-replicas 10
2384+
az containerapp env premium-ingress add -g MyResourceGroup -n MyEnvironment -w WorkloadProfileName --min-replicas 2 --max-replicas 10
23852385
"""
23862386

2387-
helps['containerapp env ingress set'] = """
2387+
helps['containerapp env premium-ingress add'] = """
23882388
type: command
2389-
short-summary: Set the ingress settings for the environment.
2389+
short-summary: Enable the premium ingress settings for the environment.
23902390
long-summary: |
23912391
Unspecified optional parameters will be cleared from any existing configuration.
23922392
examples:
2393-
- name: Set the ingress settings for the environment.
2393+
- name: Add the premium ingress settings for the environment.
23942394
text: |
2395-
az containerapp env ingress set -g MyResourceGroup -n MyEnvironment -w WorkloadProfileName --min-replicas 2 --max-replicas 10
2395+
az containerapp env premium-ingress add -g MyResourceGroup -n MyEnvironment -w WorkloadProfileName --min-replicas 2 --max-replicas 10
23962396
"""
23972397

2398-
helps['containerapp env ingress update'] = """
2398+
helps['containerapp env premium-ingress update'] = """
23992399
type: command
2400-
short-summary: Update the ingress settings for the environment.
2400+
short-summary: Update the premium ingress settings for the environment.
24012401
examples:
2402-
- name: Update the workload profile used for ingress.
2402+
- name: Update the workload profile used for premium ingress.
24032403
text: |
2404-
az containerapp env ingress update -g MyResourceGroup -n MyEnvironment -w WorkloadProfileName
2404+
az containerapp env premium-ingress update -g MyResourceGroup -n MyEnvironment -w WorkloadProfileName
24052405
"""
24062406

2407-
helps['containerapp env ingress reset'] = """
2407+
helps['containerapp env premium-ingress remove'] = """
24082408
type: command
2409-
short-summary: Removes the ingress settings and resets the system to default values.
2409+
short-summary: Removes the ingress settings and restores the system to default values.
24102410
examples:
24112411
- name: Reset the ingress settings for the environment to its default values
24122412
text: |
2413-
az containerapp env ingress reset -g MyResourceGroup -n MyEnvironment
2413+
az containerapp env premium-ingress remove -g MyResourceGroup -n MyEnvironment
24142414
"""

src/containerapp/azext_containerapp/_params.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -506,12 +506,12 @@ def load_arguments(self, _):
506506
c.argument('mode', arg_type=get_enum_type(['single', 'multiple', 'labels']), help="The active revisions mode for the container app.")
507507
c.argument('target_label', help="The label to apply to new revisions. Required for revision mode 'labels'.", is_preview=True)
508508

509-
with self.argument_context('containerapp env ingress') as c:
509+
with self.argument_context('containerapp env premium-ingress') as c:
510510
c.argument('resource_group_name', arg_type=resource_group_name_type, id_part=None)
511511
c.argument('name', options_list=['--name', '-n'], help="The name of the managed environment.")
512512
c.argument('workload_profile_name', options_list=['--workload-profile-name', '-w'], help="The workload profile to run ingress replicas on. This profile must not be shared with any container app or job.")
513513
c.argument('min_replicas', options_list=['--min-replicas'], type=int, help="Minimum number of replicas to run. Default 2, minimum 2.")
514514
c.argument('max_replicas', options_list=['--max-replicas'], type=int, help="Maximum number of replicas to run. Default 10. The upper limit is the maximum cores avalable in the workload profile.")
515-
c.argument('termination_grace_period', options_list=['--termination-grace-period', '-t'], type=int, help="Time in seconds to drain requests durring ingress shutdown. Default 500, minimum 0, maximum 3600.")
515+
c.argument('termination_grace_period', options_list=['--termination-grace-period', '-t'], type=int, help="Time in seconds to drain requests during ingress shutdown. Default 500, minimum 0, maximum 3600.")
516516
c.argument('request_idle_timeout', options_list=['--request-idle-timeout'], type=int, help="Timeout in minutes for idle requests. Default 4, minimum 1.")
517517
c.argument('header_count_limit', options_list=['--header-count-limit'], type=int, help="Limit of http headers per request. Default 100, minimum 1.")

src/containerapp/azext_containerapp/commands.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -292,8 +292,8 @@ def load_command_table(self, args):
292292
g.custom_command('add', 'add_revision_label')
293293
g.custom_command('remove', 'remove_revision_label')
294294

295-
with self.command_group('containerapp env ingress', is_preview=True) as g:
296-
g.custom_show_command('show', 'show_environment_ingress')
297-
g.custom_command('set', 'set_environment_ingress')
298-
g.custom_command('update', 'update_environment_ingress')
299-
g.custom_command('reset', 'reset_environment_ingress_to_defaults')
295+
with self.command_group('containerapp env premium-ingress', is_preview=True) as g:
296+
g.custom_show_command('show', 'show_environment_premium_ingress')
297+
g.custom_command('add', 'add_environment_premium_ingress')
298+
g.custom_command('update', 'update_environment_premium_ingress')
299+
g.custom_command('remove', 'remove_environment_premium_ingress')

src/containerapp/azext_containerapp/custom.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3712,7 +3712,7 @@ def remove_revision_label(cmd, resource_group_name, name, label, no_wait=False):
37123712
handle_raw_exception(e)
37133713

37143714

3715-
def show_environment_ingress(cmd, name, resource_group_name):
3715+
def show_environment_premium_ingress(cmd, name, resource_group_name):
37163716
_validate_subscription_registered(cmd, CONTAINER_APPS_RP)
37173717

37183718
try:
@@ -3722,14 +3722,14 @@ def show_environment_ingress(cmd, name, resource_group_name):
37223722

37233723
ingress_config = safe_get(env, "properties", "ingressConfiguration")
37243724
if not ingress_config:
3725-
return {"message": "No ingress configuration found for this environment, using default values."}
3725+
return {"message": "No premium ingress configuration found for this environment, using default values."}
37263726

37273727
return ingress_config
37283728
except Exception as e:
37293729
handle_raw_exception(e)
37303730

37313731

3732-
def set_environment_ingress(cmd, name, resource_group_name, workload_profile_name, min_replicas, max_replicas, termination_grace_period=None, request_idle_timeout=None, header_count_limit=None, no_wait=False):
3732+
def add_environment_premium_ingress(cmd, name, resource_group_name, workload_profile_name, min_replicas, max_replicas, termination_grace_period=None, request_idle_timeout=None, header_count_limit=None, no_wait=False):
37333733
_validate_subscription_registered(cmd, CONTAINER_APPS_RP)
37343734

37353735
try:
@@ -3766,7 +3766,7 @@ def set_environment_ingress(cmd, name, resource_group_name, workload_profile_nam
37663766
handle_raw_exception(e)
37673767

37683768

3769-
def update_environment_ingress(cmd, name, resource_group_name, workload_profile_name=None, min_replicas=None, max_replicas=None, termination_grace_period=None, request_idle_timeout=None, header_count_limit=None, no_wait=False):
3769+
def update_environment_premium_ingress(cmd, name, resource_group_name, workload_profile_name=None, min_replicas=None, max_replicas=None, termination_grace_period=None, request_idle_timeout=None, header_count_limit=None, no_wait=False):
37703770
_validate_subscription_registered(cmd, CONTAINER_APPS_RP)
37713771

37723772
try:
@@ -3797,7 +3797,7 @@ def update_environment_ingress(cmd, name, resource_group_name, workload_profile_
37973797
if ingress_config:
37983798
safe_set(env_patch, "properties", "ingressConfiguration", value=ingress_config)
37993799
else:
3800-
return {"message": "No changes specified for ingress configuration"}
3800+
return {"message": "No changes specified for premium ingress configuration"}
38013801

38023802
# Update the environment with the patched ingress configuration
38033803
result = ManagedEnvironmentPreviewClient.update(
@@ -3814,7 +3814,7 @@ def update_environment_ingress(cmd, name, resource_group_name, workload_profile_
38143814
handle_raw_exception(e)
38153815

38163816

3817-
def reset_environment_ingress_to_defaults(cmd, name, resource_group_name, no_wait=False):
3817+
def remove_environment_premium_ingress(cmd, name, resource_group_name, no_wait=False):
38183818
_validate_subscription_registered(cmd, CONTAINER_APPS_RP)
38193819

38203820
try:

0 commit comments

Comments
 (0)