From b00cd86b6a3d6f9d983fbdaf9cf4951ef640dc41 Mon Sep 17 00:00:00 2001 From: "Tony Chen (DevDiv)" Date: Mon, 17 Mar 2025 13:26:54 +0800 Subject: [PATCH 1/4] Add manual steps doc for connecting to SQL Database in Fabric --- .../azext_serviceconnector_passwordless/_credential_free.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/serviceconnector-passwordless/azext_serviceconnector_passwordless/_credential_free.py b/src/serviceconnector-passwordless/azext_serviceconnector_passwordless/_credential_free.py index 562eb6dd992..e2b683839b3 100644 --- a/src/serviceconnector-passwordless/azext_serviceconnector_passwordless/_credential_free.py +++ b/src/serviceconnector-passwordless/azext_serviceconnector_passwordless/_credential_free.py @@ -1016,7 +1016,7 @@ def create_aad_user(self): self.create_aad_user_in_sql(connection_args, query_list) def get_fabric_access_token(self): - return run_cli_cmd('az account get-access-token --output json --resource https://api.fabric.microsoft.com/').get('accessToken') + return run_cli_cmd('az account get-access-token --output json --resource https://analysis.windows.net/powerbi/api').get('accessToken') def set_user_admin(self, user_object_id, **kwargs): return @@ -1042,6 +1042,9 @@ def get_create_query(self): grant_q1 = "ALTER ROLE db_datareader ADD MEMBER \"{}\"".format(self.aad_username) grant_q2 = "ALTER ROLE db_datawriter ADD MEMBER \"{}\"".format(self.aad_username) grant_q3 = "ALTER ROLE db_ddladmin ADD MEMBER \"{}\"".format(self.aad_username) + + logger.warning("Manual steps required to complete this service connection. Please refer to %s for more details.", "https://learn.microsoft.com/en-us/azure/service-connector/how-to-integrate-fabric-sql#share-access-to-sql-database-in-fabric") + input("Press ENTER to continue...") return [delete_q, role_q, grant_q1, grant_q2, grant_q3] From 662332a1db332b1b13c3908a1ad6bc6673c95476 Mon Sep 17 00:00:00 2001 From: "Tony Chen (DevDiv)" Date: Fri, 25 Apr 2025 11:25:26 +0800 Subject: [PATCH 2/4] Fix blank line --- .../azext_serviceconnector_passwordless/_credential_free.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/serviceconnector-passwordless/azext_serviceconnector_passwordless/_credential_free.py b/src/serviceconnector-passwordless/azext_serviceconnector_passwordless/_credential_free.py index e2b683839b3..24d657a0180 100644 --- a/src/serviceconnector-passwordless/azext_serviceconnector_passwordless/_credential_free.py +++ b/src/serviceconnector-passwordless/azext_serviceconnector_passwordless/_credential_free.py @@ -1042,7 +1042,7 @@ def get_create_query(self): grant_q1 = "ALTER ROLE db_datareader ADD MEMBER \"{}\"".format(self.aad_username) grant_q2 = "ALTER ROLE db_datawriter ADD MEMBER \"{}\"".format(self.aad_username) grant_q3 = "ALTER ROLE db_ddladmin ADD MEMBER \"{}\"".format(self.aad_username) - + logger.warning("Manual steps required to complete this service connection. Please refer to %s for more details.", "https://learn.microsoft.com/en-us/azure/service-connector/how-to-integrate-fabric-sql#share-access-to-sql-database-in-fabric") input("Press ENTER to continue...") From 38ee6ce2cbe263c3c256af2524fb2bb8b2986520 Mon Sep 17 00:00:00 2001 From: "Tony Chen (DevDiv)" Date: Fri, 25 Apr 2025 11:32:38 +0800 Subject: [PATCH 3/4] Bump version --- src/serviceconnector-passwordless/HISTORY.rst | 4 ++++ .../azext_serviceconnector_passwordless/config.py | 2 +- src/serviceconnector-passwordless/setup.py | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/serviceconnector-passwordless/HISTORY.rst b/src/serviceconnector-passwordless/HISTORY.rst index 5a901c55f62..6c03fc5c72a 100644 --- a/src/serviceconnector-passwordless/HISTORY.rst +++ b/src/serviceconnector-passwordless/HISTORY.rst @@ -2,6 +2,10 @@ Release History =============== +3.3.2 +++++++ +* Add documentation explaining manual steps required for connecting to SQL database in Fabric. + 3.3.1 ++++++ * Change Fabric SQL token endpoint for Cloud Shell compatibility. diff --git a/src/serviceconnector-passwordless/azext_serviceconnector_passwordless/config.py b/src/serviceconnector-passwordless/azext_serviceconnector_passwordless/config.py index 73d567aa5d5..9d89bb64fcf 100644 --- a/src/serviceconnector-passwordless/azext_serviceconnector_passwordless/config.py +++ b/src/serviceconnector-passwordless/azext_serviceconnector_passwordless/config.py @@ -4,5 +4,5 @@ # -------------------------------------------------------------------------------------------- -VERSION = '3.3.1' +VERSION = '3.3.2' NAME = 'serviceconnector-passwordless' diff --git a/src/serviceconnector-passwordless/setup.py b/src/serviceconnector-passwordless/setup.py index dd650ccf574..ba7daac179e 100644 --- a/src/serviceconnector-passwordless/setup.py +++ b/src/serviceconnector-passwordless/setup.py @@ -15,7 +15,7 @@ logger.warn("Wheel is not available, disabling bdist_wheel hook") -VERSION = '3.3.1' +VERSION = '3.3.2' # The full list of classifiers is available at # https://pypi.python.org/pypi?%3Aaction=list_classifiers From 761d183405e6f373361d9f45c00a925fb5ae7ea4 Mon Sep 17 00:00:00 2001 From: "Tony Chen (DevDiv)" Date: Sun, 27 Apr 2025 11:06:00 +0800 Subject: [PATCH 4/4] Remove input --- .../azext_serviceconnector_passwordless/_credential_free.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/serviceconnector-passwordless/azext_serviceconnector_passwordless/_credential_free.py b/src/serviceconnector-passwordless/azext_serviceconnector_passwordless/_credential_free.py index 24d657a0180..9eb1602df92 100644 --- a/src/serviceconnector-passwordless/azext_serviceconnector_passwordless/_credential_free.py +++ b/src/serviceconnector-passwordless/azext_serviceconnector_passwordless/_credential_free.py @@ -1043,8 +1043,7 @@ def get_create_query(self): grant_q2 = "ALTER ROLE db_datawriter ADD MEMBER \"{}\"".format(self.aad_username) grant_q3 = "ALTER ROLE db_ddladmin ADD MEMBER \"{}\"".format(self.aad_username) - logger.warning("Manual steps required to complete this service connection. Please refer to %s for more details.", "https://learn.microsoft.com/en-us/azure/service-connector/how-to-integrate-fabric-sql#share-access-to-sql-database-in-fabric") - input("Press ENTER to continue...") + logger.warning("IMPORTANT: Manual steps required to complete this service connection. Please refer to %s for more details.", "https://learn.microsoft.com/en-us/azure/service-connector/how-to-integrate-fabric-sql#share-access-to-sql-database-in-fabric") return [delete_q, role_q, grant_q1, grant_q2, grant_q3]