{Misc.} Improve code style and prepare for pylint 2.17 (#26685)

Author: bebound

pylintrc

@@ -47,7 +47,12 @@ disable=
     redundant-u-string-prefix,
     raising-bad-type,
     unused-private-member,
-    used-before-assignment
+    used-before-assignment,
+    # These rules were added in Pylint >= 2.12, disable them to avoid making retroactive change
+    missing-timeout,
+    superfluous-parens,
+    implicit-str-concat,
+    unnecessary-dunder-call,
 
 [FORMAT]
 max-line-length=120
@@ -61,24 +66,8 @@ init-import=yes
 max-locals=25
 # Maximum number of branch for function / method body
 max-branches=20
+# Temporally disable this check as inline disable is not working, see https://github.com/pylint-dev/pylint/issues/8806
+max-statements=500
 
 [SIMILARITIES]
 min-similarity-lines=10
-
-[BASIC]
-# Naming hints based on PEP 8 (https://www.python.org/dev/peps/pep-0008/#naming-conventions).
-# Consider these guidelines and not hard rules. Read PEP 8 for more details.
-
-# The invalid-name checker must be **enabled** for these hints to be used.
-include-naming-hint=yes
-
-module-name-hint=lowercase (keep short; underscores are discouraged)
-const-name-hint=UPPER_CASE_WITH_UNDERSCORES
-class-name-hint=CapitalizedWords
-class-attribute-name-hint=lower_case_with_underscores
-attr-name-hint=lower_case_with_underscores
-method-name-hint=lower_case_with_underscores
-function-name-hint=lower_case_with_underscores
-argument-name-hint=lower_case_with_underscores
-variable-name-hint=lower_case_with_underscores
-inlinevar-name-hint=lower_case_with_underscores (short is OK)

src/azure-cli-core/azure/cli/core/aaz/_help.py

@@ -44,7 +44,7 @@ def show(self):
             key = self.keys[idx]
             if isinstance(schema, AAZObjectArg):
                 try:
-                    schema = schema[key]
+                    schema = schema[key]  # pylint: disable=unsubscriptable-object
                 except AAZUndefinedValueError:
                     # show the help of current schema
                     break

src/azure-cli-core/azure/cli/core/commands/__init__.py

@@ -724,7 +724,7 @@ def _run_jobs_serially(self, jobs, ids):
             expanded_arg, cmd_copy = job
             try:
                 results.append(self._run_job(expanded_arg, cmd_copy))
-            except(Exception, SystemExit) as ex:  # pylint: disable=broad-except
+            except (Exception, SystemExit) as ex:  # pylint: disable=broad-except
                 exceptions.append((ex, id_arg))
         return results, exceptions
 

src/azure-cli-core/azure/cli/core/extension/__init__.py

@@ -8,7 +8,7 @@
 import traceback
 import json
 import re
-from distutils.sysconfig import get_python_lib
+from distutils.sysconfig import get_python_lib  # pylint: disable=deprecated-module
 
 import pkginfo
 from knack.config import CLIConfig

src/azure-cli/azure/cli/command_modules/acr/_docker_utils.py

@@ -644,7 +644,7 @@ def request_data_from_registry(http_method,
                 raise RegistryException(
                     parse_error_message('Failed to request data due to a conflict.', response),
                     response.status_code)
-            raise Exception(parse_error_message('Could not {} the requested data.'.format(http_method), response))
+            raise Exception(parse_error_message('Could not {} the requested data.'.format(http_method), response))  # pylint: disable=broad-exception-raised
         except CLIError:
             raise
         except Exception as e:  # pylint: disable=broad-except

src/azure-cli/azure/cli/command_modules/acs/_format.py

@@ -174,7 +174,7 @@ def _func_set_preview_array(self, versions):
                 for i, _ in enumerate(versions):
                     versions[i] = self._func_set_preview(versions[i])
                 return versions
-            except(TypeError, ValueError):
+            except (TypeError, ValueError):
                 return versions
 
         @functions.signature({'types': ['string']})
@@ -184,7 +184,7 @@ def _func_set_preview(self, version):  # pylint: disable=no-self-use
                 if preview_versions.get(version, False):
                     return version + '(preview)'
                 return version
-            except(TypeError, ValueError):
+            except (TypeError, ValueError):
                 return version
 
     return CustomFunctions()

src/azure-cli/azure/cli/command_modules/acs/_loadbalancer.py

@@ -3,7 +3,7 @@
 # Licensed under the MIT License. See License.txt in the project root for license information.
 # --------------------------------------------------------------------------------------------
 
-from distutils.version import StrictVersion
+from distutils.version import StrictVersion  # pylint: disable=deprecated-module
 from types import SimpleNamespace
 
 from knack.log import get_logger

src/azure-cli/azure/cli/command_modules/acs/_roleassignments.py

@@ -309,11 +309,11 @@ def ensure_aks_acr_role_assignment(cmd, assignee, registry_id, detach=False, is_
         if not delete_role_assignments(
             cmd.cli_ctx, "acrpull", assignee, scope=registry_id, is_service_principal=is_service_principal
         ):
-            raise AzCLIError("Could not delete role assignments for ACR. " "Are you an Owner on this subscription?")
+            raise AzCLIError("Could not delete role assignments for ACR. Are you an Owner on this subscription?")
         return
 
     if not add_role_assignment(cmd, "acrpull", assignee, scope=registry_id, is_service_principal=is_service_principal):
-        raise AzCLIError("Could not create a role assignment for ACR. " "Are you an Owner on this subscription?")
+        raise AzCLIError("Could not create a role assignment for ACR. Are you an Owner on this subscription?")
     return
 
 

src/azure-cli/azure/cli/command_modules/acs/base_decorator.py

@@ -122,7 +122,7 @@ def items(self):
         return self.__store.items()
 
     def __format_count(self):
-        untouched_keys = [x for x in self.__store.keys() if x not in self.__count.keys()]
+        untouched_keys = [x for x in self.__store if x not in self.__count]
         for k in untouched_keys:
             self.__count[k] = 0
 

src/azure-cli/azure/cli/command_modules/acs/custom.py

@@ -22,7 +22,7 @@
 import uuid
 import webbrowser
 import zipfile
-from distutils.version import StrictVersion
+from distutils.version import StrictVersion  # pylint: disable=deprecated-module
 from urllib.error import URLError
 from urllib.request import urlopen