{Pylint} Fix used-before-assignment (#30348)

Author: jiasli

pylintrc

@@ -48,7 +48,6 @@ disable=
     redundant-u-string-prefix,
     raising-bad-type,
     unused-private-member,
-    used-before-assignment,
     # These rules were added in Pylint >= 2.12, disable them to avoid making retroactive change
     missing-timeout,
     superfluous-parens,

src/azure-cli/azure/cli/command_modules/acs/addonconfiguration.py

@@ -770,7 +770,7 @@ def create_data_collection_endpoint(cmd, subscription, resource_group, region, e
 def validate_data_collection_settings(dataCollectionSettings):
     if 'interval' in dataCollectionSettings.keys():
         intervalValue = dataCollectionSettings["interval"]
-    if (bool(re.match(r'^[0-9]+[m]$', intervalValue))) is False:
+    if (bool(re.match(r'^[0-9]+[m]$', intervalValue))) is False:  # pylint: disable=used-before-assignment
         raise InvalidArgumentValueError('interval format must be in <number>m')
     intervalValue = int(intervalValue.rstrip("m"))
     if intervalValue <= 0 or intervalValue > 30:
@@ -844,7 +844,7 @@ def add_monitoring_role_assignment(result, cluster_resource_id, cmd):
             cmd,
             "Monitoring Metrics Publisher",
             service_principal_msi_id,
-            is_service_principal,
+            is_service_principal,  # pylint: disable=used-before-assignment
             scope=cluster_resource_id,
         ):
             logger.warning(

src/azure-cli/azure/cli/command_modules/acs/azuremonitormetrics/recordingrules/create.py

@@ -47,7 +47,7 @@ def put_rules(cmd, default_rule_group_id, default_rule_group_name, mac_region, c
         except CLIError as e:
             error = e
     else:
-        raise error
+        raise error  # pylint: disable=used-before-assignment
 
 
 # pylint: disable=line-too-long

src/azure-cli/azure/cli/command_modules/resource/custom.py

@@ -1177,7 +1177,7 @@ def _prepare_deployment_properties_unmodified(cmd, deployment_scope, template_fi
     template_obj['resources'] = template_obj.get('resources', [])
 
     if _is_bicepparam_file_provided(parameters):
-        parameters = json.loads(bicepparam_json_content).get('parameters', {})
+        parameters = json.loads(bicepparam_json_content).get('parameters', {})  # pylint: disable=used-before-assignment
     else:
         parameters = _process_parameters(template_obj, parameters) or {}
         parameters = _get_missing_parameters(parameters, template_obj, _prompt_for_parameters, no_prompt)
@@ -1381,7 +1381,7 @@ def _prepare_stacks_templates_and_parameters(cmd, rcf, deployment_scope, deploym
     template_obj['resources'] = template_obj.get('resources', [])
 
     if _is_bicepparam_file_provided(parameters):
-        parameters = json.loads(bicepparam_json_content).get('parameters', {})
+        parameters = json.loads(bicepparam_json_content).get('parameters', {})  # pylint: disable=used-before-assignment
     else:
         parameters = _process_parameters(template_obj, parameters) or {}
         parameters = _get_missing_parameters(parameters, template_obj, _prompt_for_parameters, False)

src/azure-cli/azure/cli/command_modules/storage/_validators.py

@@ -677,7 +677,7 @@ def validator(cmd, namespace):
                 for attr in ['content_type', 'content_disposition', 'content_encoding', 'content_language',
                              'content_md5', 'cache_control']:
                     if getattr(new_props, attr) is None:
-                        setattr(new_props, attr, getattr(props, attr))
+                        setattr(new_props, attr, getattr(props, attr))  # pylint: disable=used-before-assignment
         else:
             if guess_from_file:
                 new_props = guess_content_type(ns[guess_from_file], new_props, settings_class)

src/azure-cli/azure/cli/command_modules/storage/_validators_azure_stack.py

@@ -443,7 +443,7 @@ def validator(cmd, namespace):
                 for attr in ['content_type', 'content_disposition', 'content_encoding', 'content_language',
                              'content_md5', 'cache_control']:
                     if getattr(new_props, attr) is None:
-                        setattr(new_props, attr, getattr(props, attr))
+                        setattr(new_props, attr, getattr(props, attr))  # pylint: disable=used-before-assignment
         else:
             if guess_from_file:
                 new_props = guess_content_type(ns[guess_from_file], new_props, settings_class)

src/azure-cli/azure/cli/command_modules/vm/_image_builder.py

@@ -311,7 +311,7 @@ def process_image_template_create_namespace(cmd, namespace):  # pylint: disable=
     for script in scripts:
         if script["type"] is None:
             try:
-                script["type"] = ScriptType.SHELL if likely_linux else ScriptType.POWERSHELL
+                script["type"] = ScriptType.SHELL if likely_linux else ScriptType.POWERSHELL  # pylint: disable=used-before-assignment
                 logger.info("For script %s, likely linux is %s.", script["script"], likely_linux)
             except NameError:
                 raise CLIError("Unable to infer the type of script {}.".format(script["script"]))