Refactor template spec functions to simplify subscription_id usage

Removed redundant subscription_id variable assignments in template spec-related functions. Now, subscription_id is passed directly from parsed resource ID when template_spec is provided, improving code clarity and reducing duplication.

Author: a0x1ab

src/azure-cli/azure/cli/command_modules/resource/custom.py

@@ -2302,16 +2302,14 @@ def delete_deployment_script(cmd, resource_group_name, name):
 
 
 def get_template_spec(cmd, resource_group_name=None, name=None, version=None, template_spec=None):
-    subscription_id = None
     if template_spec:
         id_parts = parse_resource_id(template_spec)
-        subscription_id = id_parts.get('subscription')
         resource_group_name = id_parts.get('resource_group')
         name = id_parts.get('name')
         version = id_parts.get('resource_name')
         if version == name:
             version = None
-    rcf = _resource_templatespecs_client_factory(cmd.cli_ctx, subscription_id=subscription_id)
+    rcf = _resource_templatespecs_client_factory(cmd.cli_ctx, subscription_id=id_parts.get('subscription') if template_spec else None)
     if version:
         return rcf.template_spec_versions.get(resource_group_name, name, version)
     retrieved_template = rcf.template_specs.get(resource_group_name, name, expand="versions")
@@ -2383,16 +2381,14 @@ def create_template_spec(cmd, resource_group_name, name, template_file=None, loc
 
 def update_template_spec(cmd, resource_group_name=None, name=None, template_spec=None, template_file=None, display_name=None,
                          description=None, version=None, version_description=None, tags=None, ui_form_definition_file=None):
-    subscription_id = None
     if template_spec:
         id_parts = parse_resource_id(template_spec)
-        subscription_id = id_parts.get('subscription')
         resource_group_name = id_parts.get('resource_group')
         name = id_parts.get('name')
         version = id_parts.get('resource_name')
         if version == name:
             version = None
-    rcf = _resource_templatespecs_client_factory(cmd.cli_ctx, subscription_id=subscription_id)
+    rcf = _resource_templatespecs_client_factory(cmd.cli_ctx, subscription_id=id_parts.get('subscription') if template_spec else None)
 
     existing_template, artifacts, input_ui_form_definition = None, None, None
     if template_file:
@@ -2448,16 +2444,14 @@ def update_template_spec(cmd, resource_group_name=None, name=None, template_spec
 
 
 def export_template_spec(cmd, output_folder, resource_group_name=None, name=None, version=None, template_spec=None):
-    subscription_id = None
     if template_spec:
         id_parts = parse_resource_id(template_spec)
-        subscription_id = id_parts.get('subscription')
         resource_group_name = id_parts.get('resource_group')
         name = id_parts.get('name')
         version = id_parts.get('resource_name')
         if version == name:
             version = None
-    rcf = _resource_templatespecs_client_factory(cmd.cli_ctx, subscription_id=subscription_id)
+    rcf = _resource_templatespecs_client_factory(cmd.cli_ctx, subscription_id=id_parts.get('subscription') if template_spec else None)
     if not version:
         raise IncorrectUsageError('Please specify the template spec version for export')
     exported_template = rcf.template_spec_versions.get(resource_group_name, name, version)
@@ -2466,16 +2460,14 @@ def export_template_spec(cmd, output_folder, resource_group_name=None, name=None
 
 
 def delete_template_spec(cmd, resource_group_name=None, name=None, version=None, template_spec=None):
-    subscription_id = None
     if template_spec:
         id_parts = parse_resource_id(template_spec)
-        subscription_id = id_parts.get('subscription')
         resource_group_name = id_parts.get('resource_group')
         name = id_parts.get('name')
         version = id_parts.get('resource_name')
         if version == name:
             version = None
-    rcf = _resource_templatespecs_client_factory(cmd.cli_ctx, subscription_id=subscription_id)
+    rcf = _resource_templatespecs_client_factory(cmd.cli_ctx, subscription_id=id_parts.get('subscription') if template_spec else None)
     if version:
         return rcf.template_spec_versions.delete(resource_group_name=resource_group_name, template_spec_name=name, template_spec_version=version)
     return rcf.template_specs.delete(resource_group_name=resource_group_name, template_spec_name=name)