fix: fixed PR recommendations

Author: feliperezende-barbosa

src/azure-cli/azure/cli/command_modules/apim/_client_factory.py

@@ -57,5 +57,6 @@ def cf_graphqlapiresolver(cli_ctx, *_):
 def cf_graphqlapiresolverpolicy(cli_ctx, *_):
     return cf_apim(cli_ctx).graph_ql_api_resolver_policy
 
+
 def cf_backend(cli_ctx, *_):
-    return cf_apim(cli_ctx).backend
+    return cf_apim(cli_ctx).backend

src/azure-cli/azure/cli/command_modules/apim/_help.py

@@ -812,11 +812,8 @@
     short-summary: unique name of the Backend to be updated
     long-summary: |
         Must be unique in the current API Management service instance.
-  - name: --if-match
-    type: string
-    short-summary: ETag of the Backend entity. ETag should match the current entity state from the service to perform an update. Use "*" for unconditional update.
 examples:
   - name: Update a Backend.
     text: |-
-        az apim backend update --service-name MyApim -g MyResourceGroup --backend-id MyBackendId --if-match "*"
-"""
+        az apim backend update --service-name MyApim -g MyResourceGroup --backend-id MyBackendId --url https://mynewbackend.com
+"""

src/azure-cli/azure/cli/command_modules/apim/_params.py

@@ -22,6 +22,7 @@
 API_TYPES = ApiType
 BACKEND_PROTOCOLS = BackendProtocol
 
+
 class ImportFormat(Enum):
     Wadl = "Wadl"
     Swagger = "Swagger"
@@ -52,7 +53,7 @@ def load_arguments(self, _):
     schema_id = CLIArgumentType(arg_group='Schema',
                                 help='Schema identifier. Must be unique in the current API Management service instance. Non-current revision has ;rev=n as a suffix where n is the revision number.')
     backend_id = CLIArgumentType(arg_group='Backend',
-                                 help='Backend identifier. Must be unique in the current API Management service instance. Non-current revision has ;rev=n as a suffix where n is the revision number.')
+                                 help='Backend identifier. Must be unique in the current API Management service instance.')
 
     from azure.cli.core.commands.parameters import tags_type
     from azure.cli.core.commands.validators import get_default_location_from_resource_group
@@ -505,14 +506,34 @@ def load_arguments(self, _):
         c.argument('resolver_id', help='Resolver identifier within a GraphQL API. Must be unique in the current API Management service instance.')
         c.argument('if_match', help='ETag of the Entity.')
 
-    with self.argument_context('apim backend') as c:
+    with self.argument_context('apim backend create') as c:
+        c.argument('service_name', options_list=['--service-name', '-n'],
+                   help='The name of the API Management service instance.')
+        c.argument('backend_id', arg_type=backend_id, help='Identifier of the Backend.')
+        c.argument('url', help='Required. Backend service URL.')
+        c.argument('protocol', arg_type=get_enum_type(BACKEND_PROTOCOLS),
+                   help='Protocol used to communicate with the backend service. Possible values include: `http`, `soap`.')
+        c.argument('description', help='Description of the Backend. May include HTML formatting tags.')
+
+    with self.argument_context('apim backend update') as c:
         c.argument('service_name', options_list=['--service-name', '-n'],
                    help='The name of the API Management service instance.')
         c.argument('backend_id', arg_type=backend_id, help='Identifier of the Backend.')
         c.argument('url', help='Required. Backend service URL.')
         c.argument('protocol', arg_type=get_enum_type(BACKEND_PROTOCOLS),
                    help='Protocol used to communicate with the backend service. Possible values include: `http`, `soap`.')
-        c.argument('title', help='Backend title.')
         c.argument('description', help='Description of the Backend. May include HTML formatting tags.')
-        c.argument('resource_id', help='Resource ID of the backend service.')
-        c.argument('if_match', help='ETag of the Entity.')
+
+    with self.argument_context('apim backend delete') as c:
+        c.argument('service_name', options_list=['--service-name', '-n'],
+                   help='The name of the API Management service instance.')
+        c.argument('backend_id', arg_type=backend_id, help='Identifier of the Backend.')
+
+    with self.argument_context('apim backend show') as c:
+        c.argument('service_name', options_list=['--service-name', '-n'],
+                   help='The name of the API Management service instance.')
+        c.argument('backend_id', arg_type=backend_id, help='Identifier of the Backend.')
+
+    with self.argument_context('apim backend list') as c:
+        c.argument('service_name', options_list=['--service-name', '-n'],
+                   help='The name of the API Management service instance.')

src/azure-cli/azure/cli/command_modules/apim/commands.py

@@ -189,6 +189,5 @@ def load_command_table(self, _):
         g.custom_show_command('show', 'apim_backend_show')
         g.custom_command('list', 'apim_backend_list')
         g.custom_command('delete', 'apim_backend_delete', confirmation=True, supports_no_wait=True)
-        g.generic_update_command('update', custom_func_name='apim_backend_update',
-                                 setter_name='update', getter_name='get', supports_no_wait=True)
-        g.wait_command('wait')
+        g.generic_update_command('update', custom_func_name='apim_backend_update', supports_no_wait=True)
+        g.wait_command('wait')

src/azure-cli/azure/cli/command_modules/apim/custom.py

@@ -1167,17 +1167,15 @@ def apim_graphql_resolver_policy_delete(
                        policy_id="policy",
                        if_match="*" if if_match is None else if_match)
 
+
 def apim_backend_create(
         client, resource_group_name, service_name, backend_id, url, protocol, description=None,
-        title=None, resource_id=None, properties=None, if_match=None, no_wait=False):
+        no_wait=False, if_match=None):
 
     parameters = BackendContract(
         url=url,
         protocol=protocol,
-        description=description,
-        title=title,
-        resource_id=resource_id,
-        properties=properties
+        description=description
     )
 
     return sdk_no_wait(no_wait, client.backend.create_or_update,
@@ -1187,15 +1185,17 @@ def apim_backend_create(
                        parameters=parameters,
                        if_match="*" if if_match is None else if_match)
 
+
 def apim_backend_delete(
         client, resource_group_name, service_name, backend_id, if_match=None, no_wait=False):
 
     return sdk_no_wait(no_wait,
-            client.backend.delete,
-            resource_group_name=resource_group_name,
-            service_name=service_name,
-            backend_id=backend_id,
-            if_match="*" if if_match is None else if_match)
+                       client.backend.delete,
+                       resource_group_name=resource_group_name,
+                       service_name=service_name,
+                       backend_id=backend_id,
+                       if_match="*" if if_match is None else if_match)
+
 
 def apim_backend_show(client, resource_group_name, service_name, backend_id):
 
@@ -1204,15 +1204,16 @@ def apim_backend_show(client, resource_group_name, service_name, backend_id):
         service_name=service_name,
         backend_id=backend_id)
 
+
 def apim_backend_list(client, resource_group_name, service_name):
 
     return client.backend.list_by_service(
         resource_group_name=resource_group_name,
         service_name=service_name)
 
+
 def apim_backend_update(
-        instance, url=None, protocol=None, description=None,
-        title=None, resource_id=None, properties=None):
+        instance, url=None, protocol=None, description=None):
 
     if url is not None:
         instance.url = url
@@ -1223,13 +1224,4 @@ def apim_backend_update(
     if description is not None:
         instance.description = description
 
-    if title is not None:
-        instance.title = title
-
-    if resource_id is not None:
-        instance.resource_id = resource_id
-
-    if properties is not None:
-        instance.properties = properties
-
-    return instance
+    return instance