Skip to content

Commit 582b673

Browse files
authored
[Service Fabric] Fix #18358: Fix the bug that az sf client-certificate add fails with remove not defined (#31632)
1 parent b101dba commit 582b673

File tree

1 file changed

+9
-2
lines changed
  • src/azure-cli/azure/cli/command_modules/servicefabric

1 file changed

+9
-2
lines changed

src/azure-cli/azure/cli/command_modules/servicefabric/custom.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -333,13 +333,20 @@ def _add_thumbprint(cluster, is_admin, thumbprint):
333333
ClientCertificateThumbprint(is_admin, thumbprint))
334334

335335
def _add_common_name(cluster, is_admin, certificate_common_name, certificate_issuer_thumbprint):
336+
remove = False
336337
for t in cluster.client_certificate_common_names:
337338
if t.certificate_common_name.lower() == certificate_common_name.lower() and t.certificate_issuer_thumbprint.lower() == certificate_issuer_thumbprint.lower():
338339
remove = t
340+
339341
if remove:
340342
cluster.client_certificate_common_names.remove(remove)
341-
cluster.client_certificate_common_names.add(ClientCertificateCommonName(
342-
is_admin, certificate_common_name, certificate_issuer_thumbprint))
343+
344+
client_certificate_common_name = ClientCertificateCommonName(
345+
is_admin=is_admin,
346+
certificate_common_name=certificate_common_name,
347+
certificate_issuer_thumbprint=certificate_issuer_thumbprint,
348+
)
349+
cluster.client_certificate_common_names.append(client_certificate_common_name)
343350
return cluster.client_certificate_common_names
344351

345352
if thumbprint:

0 commit comments

Comments
 (0)