Skip to content

Commit 593b70b

Browse files
mattboentoroMatthew Boentoro
andauthored
{RDBMS} az postgres flexible-server create: Remove the breaking change from validators and breaking_change file (#31399)
Co-authored-by: Matthew Boentoro <mboentoro@microsoft.com>
1 parent e60ab6d commit 593b70b

File tree

2 files changed

+3
-12
lines changed

2 files changed

+3
-12
lines changed

src/azure-cli/azure/cli/command_modules/rdbms/_breaking_change.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,12 @@
33
# Licensed under the MIT License. See License.txt in the project root for license information.
44
# --------------------------------------------------------------------------------------------
55

6-
from azure.cli.core.breaking_change import register_default_value_breaking_change, \
7-
register_other_breaking_change, register_logic_breaking_change
6+
from azure.cli.core.breaking_change import register_other_breaking_change, register_logic_breaking_change
87

98

109
register_logic_breaking_change('postgres flexible-server create', 'Update default value of "--sku-name"',
1110
detail='The default value will be changed from "Standard_D2s_v3" to a '
1211
'supported sku based on regional capabilities.')
13-
register_default_value_breaking_change('postgres flexible-server create', '--version', '16', '17')
14-
register_default_value_breaking_change('postgres flexible-server create', '--create-default-database', 'Enabled',
15-
'Disabled')
1612
register_other_breaking_change('postgres flexible-server update',
1713
message='User confirmation will be needed for compute and storage updates '
1814
'that trigger a restart of the server.')

src/azure-cli/azure/cli/command_modules/rdbms/validators.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -351,7 +351,7 @@ def pg_arguments_validator(db_context, location, tier, sku_name, storage_gb, ser
351351
_pg_storage_validator(storage_gb, sku_info, tier, storage_type, iops, throughput, instance)
352352
_pg_sku_name_validator(sku_name, sku_info, tier, instance)
353353
_pg_high_availability_validator(high_availability, standby_availability_zone, zone, tier, single_az, instance)
354-
_pg_version_validator(version, list_location_capability_info['server_versions'], is_create)
354+
_pg_version_validator(version, list_location_capability_info['server_versions'])
355355
pg_byok_validator(byok_identity, byok_key, backup_byok_identity, backup_byok_key, geo_redundant_backup, instance)
356356
is_microsoft_entra_auth = bool(microsoft_entra_auth is not None and microsoft_entra_auth.lower() == 'enabled')
357357
_pg_authentication_validator(password_auth, is_microsoft_entra_auth,
@@ -510,7 +510,7 @@ def _pg_storage_performance_tier_validator(performance_tier, sku_info, tier=None
510510
' Allowed values : {}'.format(storage_size, performance_tiers))
511511

512512

513-
def _pg_version_validator(version, versions, is_create):
513+
def _pg_version_validator(version, versions):
514514
if version:
515515
if version not in versions:
516516
raise CLIError('Incorrect value for --version. Allowed values : {}'.format(sorted(versions)))
@@ -519,11 +519,6 @@ def _pg_version_validator(version, versions, is_create):
519519
"We recommend selecting PostgreSQL 13 or a later version for "
520520
"all future operations.")
521521

522-
if is_create:
523-
# Warning for upcoming breaking change to default value of pg version
524-
logger.warning("The default value for the PostgreSQL server major version "
525-
"will be updating to 17 in the near future.")
526-
527522

528523
def _pg_high_availability_validator(high_availability, standby_availability_zone, zone, tier, single_az, instance):
529524
if instance:

0 commit comments

Comments
 (0)