Skip to content

Commit 5f986c8

Browse files
committed
fix queue issue to directly use azure-storage-queue sdk, not multiapi repo sdk. This is since the path in the queue sdk is hardcoded, multiapi wrap would not work
1 parent d557798 commit 5f986c8

File tree

6 files changed

+12
-8
lines changed

6 files changed

+12
-8
lines changed

src/azure-cli-core/azure/cli/core/profiles/_shared.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ class ResourceType(Enum): # pylint: disable=too-few-public-methods
118118
DATA_STORAGE_BLOB = ('azure.multiapi.storagev2.blob', None)
119119
DATA_STORAGE_FILEDATALAKE = ('azure.multiapi.storagev2.filedatalake', None)
120120
DATA_STORAGE_FILESHARE = ('azure.multiapi.storagev2.fileshare', None)
121-
DATA_STORAGE_QUEUE = ('azure.multiapi.storagev2.queue', None)
121+
DATA_STORAGE_QUEUE = ('azure.storage.queue', None)
122122
DATA_STORAGE_TABLE = ('azure.data.tables', None)
123123
DATA_BATCH = ('azure.batch', None)
124124

@@ -207,7 +207,7 @@ def default_api_version(self):
207207
ResourceType.DATA_STORAGE_BLOB: '2026-02-06',
208208
ResourceType.DATA_STORAGE_FILEDATALAKE: '2026-02-06',
209209
ResourceType.DATA_STORAGE_FILESHARE: '2026-02-06',
210-
ResourceType.DATA_STORAGE_QUEUE: '2026-02-06',
210+
ResourceType.DATA_STORAGE_QUEUE: None,
211211
ResourceType.DATA_STORAGE_TABLE: None,
212212
ResourceType.MGMT_SERVICEBUS: None,
213213
ResourceType.MGMT_EVENTHUB: None,

src/azure-cli/azure/cli/command_modules/storage/commands.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -711,13 +711,13 @@ def get_custom_sdk(custom_module, client_factory, resource_type=ResourceType.MGM
711711
transform=transform_cors_list_output)
712712

713713
queue_client_sdk = CliCommandType(
714-
operations_tmpl='azure.multiapi.storagev2.queue._queue_client#QueueClient.{}',
714+
operations_tmpl='azure.storage.queue._queue_client#QueueClient.{}',
715715
client_factory=cf_queue_client, resource_type=ResourceType.DATA_STORAGE_QUEUE)
716716

717717
with self.command_group('storage queue', command_type=queue_client_sdk, is_preview=True,
718718
custom_command_type=get_custom_sdk('queue', cf_queue_client,
719719
ResourceType.DATA_STORAGE_QUEUE),
720-
resource_type=ResourceType.DATA_STORAGE_QUEUE, min_api='2018-03-28') as g:
720+
resource_type=ResourceType.DATA_STORAGE_QUEUE) as g:
721721
from ._format import transform_boolean_for_table
722722
from ._transformers import create_boolean_result_output_transformer
723723

@@ -741,7 +741,7 @@ def get_custom_sdk(custom_module, client_factory, resource_type=ResourceType.MGM
741741
with self.command_group('storage queue policy', command_type=queue_client_sdk, is_preview=True,
742742
custom_command_type=get_custom_sdk('access_policy', cf_queue_client,
743743
ResourceType.DATA_STORAGE_QUEUE),
744-
resource_type=ResourceType.DATA_STORAGE_QUEUE, min_api='2018-03-28') as g:
744+
resource_type=ResourceType.DATA_STORAGE_QUEUE) as g:
745745
from ._transformers import (transform_acl_list_output, transform_queue_policy_output,
746746
transform_queue_policy_json_output)
747747
g.storage_custom_command_oauth('create', 'create_acl_policy')
@@ -757,7 +757,7 @@ def get_custom_sdk(custom_module, client_factory, resource_type=ResourceType.MGM
757757
with self.command_group('storage message', command_type=queue_client_sdk, is_preview=True,
758758
custom_command_type=get_custom_sdk('queue', cf_queue_client,
759759
ResourceType.DATA_STORAGE_QUEUE),
760-
resource_type=ResourceType.DATA_STORAGE_QUEUE, min_api='2018-03-28') as g:
760+
resource_type=ResourceType.DATA_STORAGE_QUEUE) as g:
761761
from ._transformers import (transform_message_list_output, transform_message_output)
762762
from ._format import transform_message_show
763763

@@ -773,13 +773,13 @@ def get_custom_sdk(custom_module, client_factory, resource_type=ResourceType.MGM
773773
g.storage_command_oauth('update', 'update_message', transform=transform_message_output)
774774

775775
queue_service_sdk = CliCommandType(
776-
operations_tmpl='azure.multiapi.storagev2.queue._queue_service_client#QueueServiceClient.{}',
776+
operations_tmpl='azure.storage.queue._queue_service_client#QueueServiceClient.{}',
777777
client_factory=cf_queue_service, resource_type=ResourceType.DATA_STORAGE_QUEUE)
778778

779779
with self.command_group('storage queue', command_type=queue_service_sdk, is_preview=True,
780780
custom_command_type=get_custom_sdk('queue', cf_queue_service,
781781
ResourceType.DATA_STORAGE_QUEUE),
782-
resource_type=ResourceType.DATA_STORAGE_QUEUE, min_api='2018-03-28') as g:
782+
resource_type=ResourceType.DATA_STORAGE_QUEUE) as g:
783783
from ._transformers import transform_queue_stats_output
784784
g.storage_command_oauth('stats', 'get_service_stats', transform=transform_queue_stats_output)
785785
g.storage_custom_command_oauth('list', 'list_queues', transform=transform_storage_list_output)

src/azure-cli/requirements.py3.Darwin.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ azure-monitor-query==1.2.0
8686
azure-multiapi-storage==1.7.0b1
8787
azure-nspkg==3.0.2
8888
azure-storage-common==1.4.2
89+
azure-storage-queue==12.15.0b1
8990
azure-synapse-accesscontrol==0.5.0
9091
azure-synapse-artifacts==0.21.0
9192
azure-synapse-managedprivateendpoints==0.4.0

src/azure-cli/requirements.py3.Linux.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ azure-monitor-query==1.2.0
8686
azure-multiapi-storage==1.7.0b1
8787
azure-nspkg==3.0.2
8888
azure-storage-common==1.4.2
89+
azure-storage-queue==12.15.0b1
8990
azure-synapse-accesscontrol==0.5.0
9091
azure-synapse-artifacts==0.21.0
9192
azure-synapse-managedprivateendpoints==0.4.0

src/azure-cli/requirements.py3.windows.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ azure-monitor-query==1.2.0
8686
azure-multiapi-storage==1.7.0b1
8787
azure-nspkg==3.0.2
8888
azure-storage-common==1.4.2
89+
azure-storage-queue==12.15.0b1
8990
azure-synapse-accesscontrol==0.5.0
9091
azure-synapse-artifacts==0.21.0
9192
azure-synapse-managedprivateendpoints==0.4.0

src/azure-cli/setup.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,7 @@
129129
'azure-monitor-query==1.2.0',
130130
'azure-multiapi-storage==1.7.0b1',
131131
'azure-storage-common~=1.4',
132+
'azure-storage-queue==12.15.0b1',
132133
'azure-synapse-accesscontrol~=0.5.0',
133134
'azure-synapse-artifacts~=0.21.0',
134135
'azure-synapse-managedprivateendpoints~=0.4.0',

0 commit comments

Comments
 (0)