[Compute] az vm disk attach: Add new parameter --new-names-of-source-snapshots-or-disks to support setting the name of create new disk from a snapshot or another disk (#32172)

Author: Jing-song

src/azure-cli/azure/cli/command_modules/vm/_params.py

@@ -548,6 +548,8 @@ def load_arguments(self, _):
         c.argument('disk_ids', nargs='+', min_api='2024-03-01', help='The disk IDs of the managed disk (space-delimited).')
         c.argument('source_snapshots_or_disks', options_list=['--source-snapshots-or-disks', '--source-resource'], nargs='+', min_api='2024-11-01', help='Create a data disk from a snapshot or another disk. Can use the ID of a disk or snapshot.')
         c.argument('source_disk_restore_point', options_list=['--source-disk-restore-point', '--source-disk-rp'], nargs='+', min_api='2024-11-01', help='create a data disk from a disk restore point. Can use the ID of a disk restore point.')
+        c.argument('new_names_of_source_snapshots_or_disks', options_list=['--new-names-of-source-snapshots-or-disks', '--new-names-of-sr'], nargs='+', min_api='2024-11-01', help='The name of create new data disk from a snapshot or another disk.')
+        c.argument('new_names_of_source_disk_restore_point', options_list=['--new-names-of-source-disk-restore-point', '--new-names-of-rp'], nargs='+', min_api='2024-11-01', help='The name of create new data disk from a disk restore point.')
 
     with self.argument_context('vm disk detach') as c:
         c.argument('disk_name', arg_type=name_arg_type, help='The data disk name.')

src/azure-cli/azure/cli/command_modules/vm/_validators.py

@@ -1892,6 +1892,21 @@ def process_vm_disk_attach_namespace(cmd, namespace):
         raise RequiredArgumentMissingError("Please use at least one of --name, --disks, --disk-ids,"
                                            " --source-snapshots-or-disks and --source-disk-restore-point")
 
+    if namespace.new_names_of_source_snapshots_or_disks and not namespace.source_snapshots_or_disks:
+        raise RequiredArgumentMissingError("Please use --source-snapshots-or-disks when using"
+                                           " --new-names-of-source-snapshots-or-disks")
+    if namespace.new_names_of_source_disk_restore_point and not namespace.source_disk_restore_point:
+        raise RequiredArgumentMissingError("Please use --source-disk-restore-point when using"
+                                           " --new-names-of-source-disk-restore-point")
+    if namespace.new_names_of_source_snapshots_or_disks and \
+            (len(namespace.new_names_of_source_snapshots_or_disks) != len(namespace.source_snapshots_or_disks)):
+        raise ArgumentUsageError("The number of --new-names-of-source-snapshots-or-disks must be the same as the number"
+                                 " of --source-snapshots-or-disks")
+    if namespace.new_names_of_source_disk_restore_point and \
+            (len(namespace.new_names_of_source_disk_restore_point) != len(namespace.source_disk_restore_point)):
+        raise ArgumentUsageError("The number of --new-names-of-source-disk-restore-point must be the same as the number"
+                                 " of --source-disk-restore-point")
+
     if namespace.disk and namespace.disks:
         raise MutuallyExclusiveArgumentError("You can only specify one of --name and --disks")
 

src/azure-cli/azure/cli/command_modules/vm/custom.py

@@ -2124,7 +2124,8 @@ def show_default_diagnostics_configuration(is_windows_os=False):
 # region VirtualMachines Disks (Managed)
 def attach_managed_data_disk(cmd, resource_group_name, vm_name, disk=None, ids=None, disks=None, new=False, sku=None,
                              size_gb=None, lun=None, caching=None, enable_write_accelerator=False, disk_ids=None,
-                             source_snapshots_or_disks=None, source_disk_restore_point=None):
+                             source_snapshots_or_disks=None, source_disk_restore_point=None,
+                             new_names_of_source_snapshots_or_disks=None, new_names_of_source_disk_restore_point=None):
     # attach multiple managed disks using disk attach API
     vm = get_vm_to_update(cmd, resource_group_name, vm_name)
     if not new and not sku and not size_gb and disk_ids is not None:
@@ -2182,14 +2183,17 @@ def attach_managed_data_disk(cmd, resource_group_name, vm_name, disk=None, ids=N
             vm.storage_profile.data_disks.append(data_disk)
         disk_lun = _get_disk_lun(vm.storage_profile.data_disks)
         if source_snapshots_or_disks is not None:
-            for disk_item in source_snapshots_or_disks:
+            if new_names_of_source_snapshots_or_disks is None:
+                new_names_of_source_snapshots_or_disks = [None] * len(source_snapshots_or_disks)
+            for disk_id, disk_name in zip(source_snapshots_or_disks, new_names_of_source_snapshots_or_disks):
                 disk = {
+                    'name': disk_name,
                     'create_option': 'Copy',
                     'caching': caching,
                     'lun': disk_lun,
                     'writeAcceleratorEnabled': enable_write_accelerator,
                     "sourceResource": {
-                        "id": disk_item
+                        "id": disk_id
                     }
                 }
                 if size_gb is not None:
@@ -2205,14 +2209,17 @@ def attach_managed_data_disk(cmd, resource_group_name, vm_name, disk=None, ids=N
                 disk_lun += 1
                 vm.storage_profile.data_disks.append(disk)
         if source_disk_restore_point is not None:
-            for disk_item in source_disk_restore_point:
+            if new_names_of_source_disk_restore_point is None:
+                new_names_of_source_disk_restore_point = [None] * len(source_disk_restore_point)
+            for disk_id, disk_name in zip(source_disk_restore_point, new_names_of_source_disk_restore_point):
                 disk = {
+                    'name': disk_name,
                     'create_option': 'Restore',
                     'caching': caching,
                     'lun': disk_lun,
                     'writeAcceleratorEnabled': enable_write_accelerator,
                     "sourceResource": {
-                        "id": disk_item
+                        "id": disk_id
                     }
                 }
                 if size_gb is not None: