Skip to content

Commit 70b6356

Browse files
authored
{AKS} Bump SDK to adopt singleapi (#31877)
1 parent 0e40f6e commit 70b6356

File tree

11 files changed

+15
-38
lines changed

11 files changed

+15
-38
lines changed

src/azure-cli-core/azure/cli/core/profiles/_shared.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ def default_api_version(self):
224224
ResourceType.MGMT_ARO: '2023-11-22',
225225
ResourceType.MGMT_DATABOXEDGE: '2021-02-01-preview',
226226
ResourceType.MGMT_CUSTOMLOCATION: '2021-03-15-preview',
227-
ResourceType.MGMT_CONTAINERSERVICE: SDKProfile('2025-05-01'),
227+
ResourceType.MGMT_CONTAINERSERVICE: None,
228228
ResourceType.MGMT_APPCONTAINERS: '2022-10-01',
229229
}
230230
}

src/azure-cli/azure/cli/command_modules/acs/_completers.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -39,16 +39,6 @@ def get_k8s_versions(cli_ctx, location):
3939
return search("values[*].patchVersions.keys(@)[]", results)
4040

4141

42-
@Completer
43-
def get_vm_size_completion_list(cmd, prefix, namespace, **kwargs): # pylint: disable=unused-argument
44-
"""Return the intersection of the VM sizes allowed by the ACS SDK with those returned by the Compute Service."""
45-
from azure.mgmt.containerservice.models import ContainerServiceVMSizeTypes
46-
47-
location = _get_location(cmd.cli_ctx, namespace)
48-
result = get_vm_sizes(cmd.cli_ctx, location)
49-
return set(r.name for r in result) & set(c.value for c in ContainerServiceVMSizeTypes)
50-
51-
5242
def get_vm_sizes(cli_ctx, location):
5343
from azure.cli.command_modules.acs._client_factory import get_compute_client
5444

src/azure-cli/azure/cli/command_modules/acs/_params.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@
88

99
from argcomplete.completers import FilesCompleter
1010
from azure.cli.command_modules.acs._completers import (
11-
get_k8s_upgrades_completion_list, get_k8s_versions_completion_list,
12-
get_vm_size_completion_list)
11+
get_k8s_upgrades_completion_list, get_k8s_versions_completion_list)
1312
from azure.cli.command_modules.acs._consts import (
1413
CONST_AZURE_KEYVAULT_NETWORK_ACCESS_PRIVATE,
1514
CONST_AZURE_KEYVAULT_NETWORK_ACCESS_PUBLIC,
@@ -460,7 +459,7 @@ def load_arguments(self, _):
460459
# nodepool paramerters
461460
c.argument('nodepool_name', default='nodepool1',
462461
help='Node pool name, up to 12 alphanumeric characters', validator=validate_nodepool_name)
463-
c.argument('node_vm_size', options_list=['--node-vm-size', '-s'], completer=get_vm_size_completion_list)
462+
c.argument('node_vm_size', options_list=['--node-vm-size', '-s'])
464463
c.argument('vm_sizes')
465464
c.argument('os_sku', arg_type=get_enum_type(node_os_skus_create), validator=validate_os_sku)
466465
c.argument('snapshot_id', validator=validate_snapshot_id)
@@ -892,7 +891,7 @@ def load_arguments(self, _):
892891
c.argument('agent_pool_name', options_list=['--nodepool-name', '--name', '-n', c.deprecate(target='--agent-pool-name', redirect='--nodepool-name', hide=True)], validator=validate_agent_pool_name, help='The node pool name.')
893892

894893
with self.argument_context('aks nodepool add') as c:
895-
c.argument('node_vm_size', options_list=['--node-vm-size', '-s'], completer=get_vm_size_completion_list)
894+
c.argument('node_vm_size', options_list=['--node-vm-size', '-s'])
896895
c.argument('vm_sizes')
897896
c.argument('vm_set_type', validator=validate_vm_set_type)
898897
c.argument('os_type')

src/azure-cli/azure/cli/command_modules/acs/commands.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -118,9 +118,9 @@ def load_command_table(self, _):
118118
confirmation='Kubernetes will be unavailable during certificate rotation process.\n' +
119119
'Are you sure you want to perform this operation?')
120120
g.custom_command('stop', 'aks_stop',
121-
supports_no_wait=True, min_api='2020-09-01')
121+
supports_no_wait=True)
122122
g.command('start', 'begin_start',
123-
supports_no_wait=True, min_api='2020-09-01')
123+
supports_no_wait=True)
124124
g.wait_command('wait')
125125
g.custom_command('use-dev-spaces', 'aks_use_dev_spaces',
126126
deprecate_info=g.deprecate())
@@ -188,7 +188,7 @@ def load_command_table(self, _):
188188
client_factory=cf_snapshots,
189189
deprecate_info=self.deprecate(
190190
redirect='aks nodepool snapshot', hide=True),
191-
min_api='2021-08-01') as g:
191+
) as g:
192192
g.custom_command('list', 'aks_nodepool_snapshot_list',
193193
deprecate_info=g.deprecate(
194194
redirect='aks nodepool snapshot list'),
@@ -207,7 +207,7 @@ def load_command_table(self, _):
207207
with self.command_group('aks nodepool snapshot',
208208
snapshot_sdk,
209209
client_factory=cf_snapshots,
210-
min_api='2021-08-01') as g:
210+
) as g:
211211
g.custom_command('list', 'aks_nodepool_snapshot_list',
212212
table_transformer=aks_list_nodepool_snapshot_table_format)
213213
g.custom_show_command('show', 'aks_nodepool_snapshot_show',

src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_agentpool_decorator.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,7 @@ def setUp(self):
5858

5959
def test__init__(self):
6060
# load models directly (instead of through the `get_sdk` method provided by the cli component)
61-
from azure.cli.core.profiles._shared import AZURE_API_PROFILES
62-
63-
sdk_profile = AZURE_API_PROFILES["latest"][self.resource_type]
64-
api_version = sdk_profile.default_api_version
65-
module_name = "azure.mgmt.containerservice.v{}.models".format(api_version.replace("-", "_"))
61+
module_name = "azure.mgmt.containerservice.models"
6662
module = importlib.import_module(module_name)
6763

6864
standalone_models = AKSAgentPoolModels(self.cmd, self.resource_type, AgentPoolDecoratorMode.STANDALONE)

src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_base_decorator.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,7 @@ def setUp(self):
3737

3838
def test_models(self):
3939
# load models directly (instead of through the `get_sdk` method provided by the cli component)
40-
from azure.cli.core.profiles._shared import AZURE_API_PROFILES
41-
42-
sdk_profile = AZURE_API_PROFILES["latest"][ResourceType.MGMT_CONTAINERSERVICE]
43-
api_version = sdk_profile.default_api_version
44-
module_name = "azure.mgmt.containerservice.v{}.models".format(api_version.replace("-", "_"))
40+
module_name = "azure.mgmt.containerservice.models"
4541
module = importlib.import_module(module_name)
4642

4743
models = BaseAKSModels(self.cmd, ResourceType.MGMT_CONTAINERSERVICE)

src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_managed_cluster_decorator.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -94,11 +94,7 @@ def test_models(self):
9494
models = AKSManagedClusterModels(self.cmd, ResourceType.MGMT_CONTAINERSERVICE)
9595

9696
# load models directly (instead of through the `get_sdk` method provided by the cli component)
97-
from azure.cli.core.profiles._shared import AZURE_API_PROFILES
98-
99-
sdk_profile = AZURE_API_PROFILES["latest"][ResourceType.MGMT_CONTAINERSERVICE]
100-
api_version = sdk_profile.default_api_version
101-
module_name = "azure.mgmt.containerservice.v{}.models".format(api_version.replace("-", "_"))
97+
module_name = "azure.mgmt.containerservice.models"
10298
module = importlib.import_module(module_name)
10399

104100
# load balancer models

src/azure-cli/requirements.py3.Darwin.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ azure-mgmt-cognitiveservices==13.5.0
3232
azure-mgmt-compute==34.1.0
3333
azure-mgmt-containerinstance==10.2.0b1
3434
azure-mgmt-containerregistry==14.1.0b1
35-
azure-mgmt-containerservice==38.0.0
35+
azure-mgmt-containerservice==39.0.0
3636
azure-mgmt-core==1.6.0
3737
azure-mgmt-cosmosdb==9.8.0
3838
azure-mgmt-databoxedge==1.0.0

src/azure-cli/requirements.py3.Linux.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ azure-mgmt-cognitiveservices==13.5.0
3232
azure-mgmt-compute==34.1.0
3333
azure-mgmt-containerinstance==10.2.0b1
3434
azure-mgmt-containerregistry==14.1.0b1
35-
azure-mgmt-containerservice==38.0.0
35+
azure-mgmt-containerservice==39.0.0
3636
azure-mgmt-core==1.6.0
3737
azure-mgmt-cosmosdb==9.8.0
3838
azure-mgmt-databoxedge==1.0.0

src/azure-cli/requirements.py3.windows.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ azure-mgmt-cognitiveservices==13.5.0
3232
azure-mgmt-compute==34.1.0
3333
azure-mgmt-containerinstance==10.2.0b1
3434
azure-mgmt-containerregistry==14.1.0b1
35-
azure-mgmt-containerservice==38.0.0
35+
azure-mgmt-containerservice==39.0.0
3636
azure-mgmt-core==1.6.0
3737
azure-mgmt-cosmosdb==9.8.0
3838
azure-mgmt-databoxedge==1.0.0

0 commit comments

Comments
 (0)