{Pylint} Fix use-dict-literal (#30308)

Author: atombrella

pylintrc

@@ -42,7 +42,6 @@ disable=
     use-maxsplit-arg,
     arguments-renamed,
     consider-using-in,
-    use-dict-literal,
     consider-using-dict-items,
     consider-using-enumerate,
     # These rules were added in Pylint >= 2.12, disable them to avoid making retroactive change

scripts/temp_help/help_convert.py

@@ -173,23 +173,23 @@ def get_all_mod_names():
 
 def _get_new_yaml_dict(help_dict):
 
-    result = dict(version=1, content=[])
+    result = {"version": 1, "content": []}
     content = result['content']
 
     for command_or_group, yaml_text in help_dict.items():
         help_dict = yaml.safe_load(yaml_text)
 
         type = help_dict["type"]
 
-        elem = {type: dict(name=command_or_group)}
+        elem = {type: {"name": command_or_group}}
         elem_content = elem[type]
 
         _convert_summaries(old_dict=help_dict, new_dict=elem_content)
 
         if "parameters" in help_dict:
             parameters = []
             for param in help_dict["parameters"]:
-                new_param = dict()
+                new_param = {}
                 if "name" in param:
                     options = param["name"].split()
                     new_param["name"] = max(options, key=lambda x: len(x))
@@ -205,7 +205,7 @@ def _get_new_yaml_dict(help_dict):
         if "examples" in help_dict:
             elem_examples = []
             for ex in help_dict["examples"]:
-                new_ex = dict()
+                new_ex = {}
                 if "name" in ex:
                     new_ex["summary"] = ex["name"]
                 if "text" in ex:

src/azure-cli-core/azure/cli/core/aaz/_field_value.py

@@ -449,7 +449,7 @@ def to_serialized_data(self, processor=None, keep_undefined_in_list=False,  # py
 
 class AAZIdentityObject(AAZObject):  # pylint: disable=too-few-public-methods
     def to_serialized_data(self, processor=None, **kwargs):
-        calculate_data = dict()
+        calculate_data = {}
         if self._data == AAZUndefined:
             result = AAZUndefined
 

src/azure-cli-core/azure/cli/core/command_recommender.py

@@ -462,7 +462,7 @@ def get_parameter_kwargs(args):
     :type: dict
     """
 
-    parameter_kwargs = dict()
+    parameter_kwargs = {}
     for index, parameter in enumerate(args):
         if parameter.startswith('-'):
 
@@ -501,7 +501,7 @@ def get_user_param_value(target_param):
         :return: The replaced value for target_param
         :type: str
         """
-        standard_source_kwargs = dict()
+        standard_source_kwargs = {}
 
         for param, val in source_kwargs.items():
             if param in param_mappings:

src/azure-cli-core/azure/cli/core/commands/command_operation.py

@@ -68,8 +68,7 @@ def get_op_handler(self, op_path):
     def load_getter_op_arguments(self, getter_op_path, cmd_args=None):
         """ Load arguments from function signature of getter command op """
         op = self.get_op_handler(getter_op_path)
-        getter_args = dict(
-            extract_args_from_signature(op, excluded_params=EXCLUDED_PARAMS))
+        getter_args = dict(extract_args_from_signature(op, excluded_params=EXCLUDED_PARAMS))
         cmd_args = cmd_args or {}
         cmd_args.update(getter_args)
         # The cmd argument is required when calling self.handler function.

src/azure-cli-core/azure/cli/core/commands/parameters.py

@@ -420,7 +420,7 @@ def expand(self, dest, model_type, group_name=None, patches=None):
             return
 
         if not patches:
-            patches = dict()
+            patches = {}
 
         # fetch the documentation for model parameters first. for models, which are the classes
         # derive from msrest.serialization.Model and used in the SDK API to carry parameters, the
@@ -440,7 +440,7 @@ def _expansion_validator_impl(namespace):
                 :return: The argument of specific type.
                 """
                 ns = vars(namespace)
-                kwargs = dict((k, ns[k]) for k in ns if k in set(expanded_arguments))
+                kwargs = {k: ns[k] for k in ns if k in set(expanded_arguments)}
 
                 setattr(namespace, assigned_arg, model_type(**kwargs))
 

src/azure-cli-core/azure/cli/core/commands/template_create.py

@@ -59,22 +59,22 @@ def _validate_name_or_id(
         resource_id_parts = parse_resource_id(property_value)
         value_supplied_was_id = True
     elif has_parent:
-        resource_id_parts = dict(
-            name=parent_value,
-            resource_group=resource_group_name,
-            namespace=parent_type.split('/')[0],
-            type=parent_type.split('/')[1],
-            subscription=get_subscription_id(cli_ctx),
-            child_name_1=property_value,
-            child_type_1=property_type)
+        resource_id_parts = {
+            "name": parent_value,
+            "resource_group": resource_group_name,
+            "namespace": parent_type.split('/')[0],
+            "type": parent_type.split('/')[1],
+            "subscription": get_subscription_id(cli_ctx),
+            "child_name_1": property_value,
+            "child_type_1": property_type}
         value_supplied_was_id = False
     else:
-        resource_id_parts = dict(
-            name=property_value,
-            resource_group=resource_group_name,
-            namespace=property_type.split('/')[0],
-            type=property_type.split('/')[1],
-            subscription=get_subscription_id(cli_ctx))
+        resource_id_parts = {
+            "name": property_value,
+            "resource_group": resource_group_name,
+            "namespace": property_type.split('/')[0],
+            "type": property_type.split('/')[1],
+            "subscription": get_subscription_id(cli_ctx)}
         value_supplied_was_id = False
     return (resource_id_parts, value_supplied_was_id)
 

src/azure-cli-core/azure/cli/core/tests/test_util.py

@@ -514,7 +514,7 @@ def test_handle_exception_httpoperationerror_typical_response_error(self, mock_l
         # create test HttpOperationError Exception
         err_msg = "Bad Request because of some incorrect param"
         err_code = "BadRequest"
-        err = dict(error=dict(code=err_code, message=err_msg))
+        err = {"error": {"code": err_code, "message": err_msg}}
         response_text = json.dumps(err)
         mock_http_error = self._get_mock_HttpOperationError(response_text)
 
@@ -533,7 +533,7 @@ def test_handle_exception_httpoperationerror_error_key_has_string_value(self, mo
 
         # create test HttpOperationError Exception
         err_msg = "BadRequest"
-        err = dict(error=err_msg)
+        err = {"error": err_msg}
         response_text = json.dumps(err)
         mock_http_error = self._get_mock_HttpOperationError(response_text)
 

src/azure-cli-telemetry/azure/cli/telemetry/components/telemetry_client.py

@@ -23,7 +23,7 @@ class CliTelemetryClient:
     def __init__(self, batch=100, sender=None):
         from azure.cli.telemetry.components.telemetry_logging import get_logger
 
-        self._clients = dict()
+        self._clients = {}
         self._counter = 0
         self._batch = batch
         self._sender = sender or _NoRetrySender

src/azure-cli-testsdk/azure/cli/testsdk/scenario_tests/tests/test_recording_processor.py

@@ -107,11 +107,14 @@ def test_subscription_recording_processor_for_response(self):
 
         for template in body_templates:
             mock_sub_id = str(uuid.uuid4())
-            mock_response = dict({'body': {}})
-            mock_response['body']['string'] = template.format(mock_sub_id)
-            mock_response['headers'] = {'Location': [location_header_template.format(mock_sub_id)],
-                                        'azure-asyncoperation': [asyncoperation_header_template.format(mock_sub_id)],
-                                        'content-type': ['application/json']}
+            mock_response = {
+                'body': {'string': template.format(mock_sub_id)},
+                'headers': {
+                    'Location': [location_header_template.format(mock_sub_id)],
+                    'azure-asyncoperation': [asyncoperation_header_template.format(mock_sub_id)],
+                    'content-type': ['application/json'],
+                }
+            }
             rp.process_response(mock_response)
             self.assertEqual(mock_response['body']['string'], template.format(replaced_subscription_id))
 
@@ -127,11 +130,12 @@ def test_recording_processor_skip_body_on_unrecognized_content_type(self):
         rp = SubscriptionRecordingProcessor(replaced_subscription_id)
 
         mock_sub_id = str(uuid.uuid4())
-        mock_response = dict({'body': {}})
-        mock_response['body']['string'] = mock_sub_id
-        mock_response['headers'] = {
-            'Location': [location_header_template.format(mock_sub_id)],
-            'content-type': ['application/foo']
+        mock_response = {
+            'body': {'string': mock_sub_id},
+            'headers': {
+                'Location': [location_header_template.format(mock_sub_id)],
+                'content-type': ['application/foo'],
+            }
         }
 
         # action