Skip to content

Commit af4a55c

Browse files
committed
mi-telemetry
1 parent 6de24b9 commit af4a55c

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

src/azure-cli-core/azure/cli/core/_profile.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1022,6 +1022,8 @@ def _create_identity_instance(cli_ctx, authority, tenant_id=None, client_id=None
10221022
def _use_msal_managed_identity(cli_ctx):
10231023
# This indicates an Azure Arc-enabled server
10241024
from msal.managed_identity import get_managed_identity_source, AZURE_ARC
1025+
from azure.cli.core.telemetry import set_use_msal_managed_identity
10251026
# PREVIEW: Use core.use_msal_managed_identity=true to enable managed identity authentication with MSAL
10261027
use_msal_managed_identity = cli_ctx.config.getboolean('core', 'use_msal_managed_identity', fallback=False)
1028+
set_use_msal_managed_identity(use_msal_managed_identity)
10271029
return use_msal_managed_identity or get_managed_identity_source() == AZURE_ARC

src/azure-cli-core/azure/cli/core/telemetry.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ def __init__(self, correlation_id=None, application=None):
7878
self.enable_broker_on_windows = None
7979
self.msal_telemetry = None
8080
self.login_experience_v2 = None
81+
self.use_msal_managed_identity = None
8182

8283
def add_event(self, name, properties):
8384
for key in self.instrumentation_key:
@@ -234,6 +235,7 @@ def _get_azure_cli_properties(self):
234235
set_custom_properties(result, 'EnableBrokerOnWindows', str(self.enable_broker_on_windows))
235236
set_custom_properties(result, 'MsalTelemetry', self.msal_telemetry)
236237
set_custom_properties(result, 'LoginExperienceV2', str(self.login_experience_v2))
238+
set_custom_properties(result, 'UseMsalManagedIdentity', str(self.use_msal_managed_identity))
237239

238240
return result
239241

@@ -469,7 +471,7 @@ def set_region_identified(region_input, region_identified):
469471
# Record the region we have recommended to customers
470472
_session.region_identified = region_identified
471473

472-
474+
# region authentication-related
473475
@decorators.suppress_all_exceptions()
474476
def set_broker_info(enable_broker_on_windows):
475477
# Log the value of `enable_broker_on_windows`
@@ -487,6 +489,12 @@ def set_login_experience_v2(login_experience_v2):
487489
_session.login_experience_v2 = login_experience_v2
488490

489491

492+
@decorators.suppress_all_exceptions()
493+
def set_use_msal_managed_identity(use_msal_managed_identity):
494+
_session.use_msal_managed_identity = use_msal_managed_identity
495+
496+
# endregion
497+
490498
@decorators.suppress_all_exceptions()
491499
def set_user_agent(user_agent):
492500
if user_agent:

0 commit comments

Comments
 (0)