{Pylint} Fix superfluous-parens (#30361)

Author: bebound

pylintrc

@@ -45,7 +45,6 @@ disable=
     consider-using-enumerate,
     # These rules were added in Pylint >= 2.12, disable them to avoid making retroactive change
     missing-timeout,
-    superfluous-parens,
     unnecessary-dunder-call,
     # These rules were added in Pylint >= 3.2
     possibly-used-before-assignment,

src/azure-cli-core/azure/cli/core/_profile.py

@@ -691,7 +691,7 @@ def refresh_accounts(self):
             if user_name in refreshed_list:
                 continue
             refreshed_list.add(user_name)
-            is_service_principal = (s[_USER_ENTITY][_USER_TYPE] == _SERVICE_PRINCIPAL)
+            is_service_principal = s[_USER_ENTITY][_USER_TYPE] == _SERVICE_PRINCIPAL
             tenant = s[_TENANT_ID]
             subscriptions = []
             try:

src/azure-cli-core/azure/cli/core/commands/arm.py

@@ -258,7 +258,7 @@ def parse_ids_arguments(_, command, args):
             # ensure the required parameters are provided if --ids is not
             errors = [arg for arg in required_args if getattr(namespace, arg.name, None) is None]
             if errors:
-                missing_required = ' '.join((arg.options_list[0] for arg in errors))
+                missing_required = ' '.join(arg.options_list[0] for arg in errors)
                 raise CLIError('({} | {}) are required'.format(missing_required, '--ids'))
             return
 

src/azure-cli-core/azure/cli/core/extension/_homebrew_patch.py

@@ -14,7 +14,7 @@
 
 
 def is_homebrew():
-    return any((p.startswith(HOMEBREW_CELLAR_PATH) for p in sys.path))
+    return any(p.startswith(HOMEBREW_CELLAR_PATH) for p in sys.path)
 
 
 # A workaround for https://github.com/Azure/azure-cli/issues/4428

src/azure-cli-core/azure/cli/core/extension/_index.py

@@ -44,7 +44,7 @@ def get_index(index_url=None, cli_ctx=None):
 
     for try_number in range(TRIES):
         try:
-            response = requests.get(index_url, verify=(not should_disable_connection_verify()))
+            response = requests.get(index_url, verify=not should_disable_connection_verify())
             if response.status_code == 200:
                 return response.json()
             msg = ERR_TMPL_NON_200.format(response.status_code, index_url)

src/azure-cli-core/azure/cli/core/extension/operations.py

@@ -65,7 +65,7 @@ def _whl_download_from_url(url_parse_result, ext_file):
     import requests
     from azure.cli.core.util import should_disable_connection_verify
     url = url_parse_result.geturl()
-    r = requests.get(url, stream=True, verify=(not should_disable_connection_verify()))
+    r = requests.get(url, stream=True, verify=not should_disable_connection_verify())
     if r.status_code != 200:
         raise CLIError("Request to {} failed with {}".format(url, r.status_code))
     with open(ext_file, 'wb') as f:

src/azure-cli-core/azure/cli/core/parser.py

@@ -32,7 +32,7 @@
                        "To learn more about extensions, please visit "
                        "'https://docs.microsoft.com/cli/azure/azure-cli-extensions-overview'")
 
-OVERVIEW_REFERENCE = ("https://aka.ms/cli_ref")
+OVERVIEW_REFERENCE = "https://aka.ms/cli_ref"
 
 
 class IncorrectUsageError(CLIError):

src/azure-cli/azure/cli/command_modules/acr/_docker_utils.py

@@ -100,7 +100,7 @@ def _handle_challenge_phase(login_server,
 
     request_url = 'https://' + login_server + '/v2/'
     logger.debug(add_timestamp("Sending a HTTP Get request to {}".format(request_url)))
-    challenge = requests.get(request_url, verify=(not should_disable_connection_verify()))
+    challenge = requests.get(request_url, verify=not should_disable_connection_verify())
 
     if challenge.status_code != 401 or 'WWW-Authenticate' not in challenge.headers:
         from ._errors import CONNECTIVITY_CHALLENGE_ERROR
@@ -164,7 +164,7 @@ def _get_aad_token_after_challenge(cli_ctx,
 
     logger.debug(add_timestamp("Sending a HTTP Post request to {}".format(authhost)))
     response = requests.post(authhost, urlencode(content), headers=headers,
-                             verify=(not should_disable_connection_verify()))
+                             verify=not should_disable_connection_verify())
 
     if response.status_code == 429:
         if is_diagnostics_context:
@@ -200,7 +200,7 @@ def _get_aad_token_after_challenge(cli_ctx,
 
     logger.debug(add_timestamp("Sending a HTTP Post request to {}".format(authhost)))
     response = requests.post(authhost, urlencode(content), headers=headers,
-                             verify=(not should_disable_connection_verify()))
+                             verify=not should_disable_connection_verify())
 
     if response.status_code not in [200]:
         from ._errors import CONNECTIVITY_ACCESS_TOKEN_ERROR
@@ -301,7 +301,7 @@ def _get_token_with_username_and_password(login_server,
 
     logger.debug(add_timestamp("Sending a HTTP Post request to {}".format(authhost)))
     response = requests.post(authhost, urlencode(content), headers=headers,
-                             verify=(not should_disable_connection_verify()))
+                             verify=not should_disable_connection_verify())
 
     if response.status_code != 200:
         from ._errors import CONNECTIVITY_ACCESS_TOKEN_ERROR
@@ -365,7 +365,7 @@ def _get_credentials(cmd,  # pylint: disable=too-many-statements
     url = 'https://' + login_server + '/v2/'
     try:
         logger.debug(add_timestamp("Sending a HTTP Get request to {}".format(url)))
-        challenge = requests.get(url, verify=(not should_disable_connection_verify()))
+        challenge = requests.get(url, verify=not should_disable_connection_verify())
         if challenge.status_code == 403:
             raise CLIError("Looks like you don't have access to registry '{}'. "
                            "To see configured firewall rules, run 'az acr show --query networkRuleSet --name {}'. "

src/azure-cli/azure/cli/command_modules/acr/check_health.py

@@ -234,7 +234,7 @@ def _get_registry_status(login_server, registry_name, ignore_errors):
     try:
         request_url = 'https://' + login_server + '/v2/'
         logger.debug(add_timestamp("Sending a HTTP GET request to {}".format(request_url)))
-        challenge = requests.get(request_url, verify=(not should_disable_connection_verify()))
+        challenge = requests.get(request_url, verify=not should_disable_connection_verify())
     except SSLError:
         from ._errors import CONNECTIVITY_SSL_ERROR
         _handle_error(CONNECTIVITY_SSL_ERROR.format_error_message(login_server), ignore_errors)
@@ -334,7 +334,7 @@ def _check_registry_health(cmd, registry_name, ignore_errors):
                         if v.client_id == client_id:
                             from azure.core.exceptions import HttpResponseError
                             try:
-                                valid_identity = (resolve_identity_client_id(cmd.cli_ctx, k) == client_id)
+                                valid_identity = resolve_identity_client_id(cmd.cli_ctx, k) == client_id
                             except HttpResponseError:
                                 pass
             if not valid_identity:

src/azure-cli/azure/cli/command_modules/acr/pack.py

@@ -63,7 +63,7 @@ def acr_pack_build(cmd,  # pylint: disable=too-many-locals
 
     registry_prefixes = '$Registry/', registry.login_server + '/'
     # If the image name doesn't have any required prefix, add it
-    if all((not image_name.startswith(prefix) for prefix in registry_prefixes)):
+    if all(not image_name.startswith(prefix) for prefix in registry_prefixes):
         original_image_name = image_name
         image_name = registry_prefixes[0] + image_name
         logger.debug('Modified image name from %s to %s', original_image_name, image_name)