Skip to content

Commit b59fddc

Browse files
samkretertjprescott
authored andcommitted
Removing Warnings for Cloudshell Proxy (#7605)
* removing warnings for cloudshell proxy * updating code owners for the container modules * Updating how env var is accessed * fixing formatting error in string message * removing unused import
1 parent ed3149f commit b59fddc

File tree

4 files changed

+12
-10
lines changed

4 files changed

+12
-10
lines changed

.github/CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
/src/command_modules/azure-cli-cdn/ @tjprescott
1616
/src/command_modules/azure-cli-cosmosdb/ @dmakwana
1717
/src/command_modules/azure-cli-cloud/ @yugangw-msft
18-
/src/command_modules/azure-cli-container/ @yolo3301
18+
/src/command_modules/azure-cli-container/ @samkreter
1919
/src/command_modules/azure-cli-consumption/ @sandeepnl
2020
/src/command_modules/azure-cli-dls/ @lewu-msft
2121
/src/command_modules/azure-cli-eventgrid/ @kalyanaj

src/command_modules/azure-cli-acs/HISTORY.rst

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22
33
Release History
44
===============
5+
6+
2.3.9
7+
+++++
8+
* Minor fixes
9+
510
2.3.8
611
+++++
712
* Minor fixes.

src/command_modules/azure-cli-acs/azure/cli/command_modules/acs/custom.py

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
from dateutil.relativedelta import relativedelta
3232
from knack.log import get_logger
3333
from knack.util import CLIError
34-
from knack.prompting import prompt_y_n
3534
from msrestazure.azure_exceptions import CloudError
3635
import requests
3736

@@ -1357,16 +1356,14 @@ def aks_browse(cmd, client, resource_group_name, name, disable_browser=False, li
13571356
raise CLIError("Couldn't find the Kubernetes dashboard pod.")
13581357
# launch kubectl port-forward locally to access the remote dashboard
13591358
if in_cloud_console() and enable_cloud_console_aks_browse:
1360-
logger.warning('***WARNING***')
1361-
logger.warning('Browsing the kubernetes dashboard in Cloud Shell is an alpha feature.')
1362-
logger.warning('The browse URL is currently obfuscated but not authenticated.')
1363-
logger.warning('Do not share this URL.')
1364-
if not prompt_y_n('Proceed?'):
1365-
raise CLIError("Browse aborted.")
13661359
# TODO: better error handling here.
13671360
response = requests.post('http://localhost:8888/openport/8001')
13681361
result = json.loads(response.text)
1369-
logger.warning('To view the console, please open % in a new tab', result['url'])
1362+
term_id = os.environ.get('ACC_TERM_ID')
1363+
if term_id:
1364+
response = requests.post('http://localhost:8888/openLink/{}'.format(term_id),
1365+
json={"url": result['url']})
1366+
logger.warning('To view the console, please open %s in a new tab', result['url'])
13701367
else:
13711368
logger.warning('Proxy running on %s', proxy_url)
13721369

src/command_modules/azure-cli-acs/setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
logger.warn("Wheel is not available, disabling bdist_wheel hook")
1515
cmdclass = {}
1616

17-
VERSION = "2.3.8"
17+
VERSION = "2.3.9"
1818
CLASSIFIERS = [
1919
'Development Status :: 5 - Production/Stable',
2020
'Intended Audience :: Developers',

0 commit comments

Comments
 (0)