Skip to content

Commit bbe21c0

Browse files
committed
Address code review feedback
- Add explanatory comment for Linux-only deduplication logic - Add debug logging when no Java versions found in Windows container settings
1 parent 9deca7b commit bbe21c0

File tree

1 file changed

+7
-1
lines changed
  • src/azure-cli/azure/cli/command_modules/appservice

1 file changed

+7
-1
lines changed

src/azure-cli/azure/cli/command_modules/appservice/custom.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6152,7 +6152,10 @@ def _get_raw_stacks_from_api(self):
61526152
return list(self._client.provider.get_web_app_stacks(stack_os_type=None))
61536153

61546154
def _parse_raw_stacks(self, stacks):
6155-
seen_runtimes = set() # Track seen runtime display names to avoid duplicates
6155+
# Track seen runtime display names to avoid duplicates in Linux parsing.
6156+
# Linux Java containers (e.g., JBOSSEAP) can produce duplicate entries across major versions.
6157+
# Windows parsing doesn't have this issue due to its different structure.
6158+
seen_runtimes = set()
61566159
for lang in stacks:
61576160
for major_version in lang.major_versions:
61586161
if self._linux:
@@ -6415,6 +6418,9 @@ def _parse_major_version_windows(self, major_version, parsed_results, config_map
64156418
container_version = container_settings.java_container_version
64166419
# Get Java versions from the container's runtimes array
64176420
javas = self._get_java_versions_from_windows_container(container_settings)
6421+
if not javas:
6422+
logger.debug("No Java versions found in Windows container settings for "
6423+
"container '%s' (version: '%s')", java_container, container_version)
64186424
for java in javas:
64196425
runtime = self.get_windows_java_runtime(
64206426
java,

0 commit comments

Comments
 (0)