Skip to content

Commit de7832e

Browse files
committed
[Refractor] - Resolve copilot suggestion
1 parent 0b8a7bc commit de7832e

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

src/azure-cli/azure/cli/command_modules/vm/_vm_utils.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -771,7 +771,8 @@ def assign_identity(cli_ctx, getter, setter, identity_role=None, identity_scope=
771771

772772
# create role assignment:
773773
if identity_scope:
774-
principal_id = resource.get('identity', {}).get('principal_id')
774+
principal_id = resource.get('identity', {}).get('principalId') or \
775+
resource.get('identity', {}).get('principal_id')
775776

776777
identity_role_id = resolve_role_id(cli_ctx, identity_role, identity_scope)
777778
assignments_client = get_mgmt_service_client(cli_ctx, ResourceType.MGMT_AUTHORIZATION).role_assignments

src/azure-cli/azure/cli/command_modules/vm/custom.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2611,14 +2611,15 @@ def setter(resource_group_name, vm_name, vm):
26112611
from ._vm_utils import IdentityType
26122612
if vm.get('identity') and vm.get('identity').get('type') == IdentityType.USER_ASSIGNED.value:
26132613
command_args['mi_user_assigned'] = \
2614-
([key for key in list(vm.get('identity', {}).get('userAssignedIdentities', {}).keys())] +
2615-
['UserAssigned'])
2614+
vm.get('identity', {}).get('userAssignedIdentities', {}).keys() + ['UserAssigned']
2615+
# NOTE: The literal 'UserAssigned' is intentionally appended as a marker for
2616+
# VMIdentityRemove._format_content, which uses it to apply special handling
2617+
# for purely user-assigned identities. It is not a real identity resource ID.
26162618
elif vm.get('identity') and vm.get('identity').get('type') == IdentityType.SYSTEM_ASSIGNED.value:
26172619
command_args['mi_user_assigned'] = []
26182620
command_args['mi_system_assigned'] = 'True'
26192621
elif vm.get('identity') and vm.get('identity').get('type') == IdentityType.SYSTEM_ASSIGNED_USER_ASSIGNED.value:
2620-
command_args['mi_user_assigned'] = \
2621-
[key for key in list(vm.get('identity', {}).get('userAssignedIdentities', {}).keys())]
2622+
command_args['mi_user_assigned'] = vm.get('identity', {}).get('userAssignedIdentities', {}).keys()
26222623
command_args['mi_system_assigned'] = 'True'
26232624
else:
26242625
command_args['mi_user_assigned'] = []

src/azure-cli/azure/cli/command_modules/vm/operations/vm.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ def _format_content(self, content):
197197
for key in list(identities.keys()):
198198
identities[key] = None
199199

200-
if len(content.get('identity', {}).get('userAssignedIdentities', {}).keys()) < 1:
200+
if not content.get('identity', {}).get('userAssignedIdentities', {}):
201201
content['identity']['userAssignedIdentities'] = None
202202

203203
return json.dumps(content)

0 commit comments

Comments
 (0)