add creation same check

Author: xfz11

src/azure-cli/azure/cli/command_modules/serviceconnector/_params.py

@@ -191,6 +191,12 @@ def add_connstr_props_argument(context):
                      validator=validate_connstr_props)
 
 
+def add_force_create_arguments(context):
+    context.argument('force', options_list=['--force', '-f'],
+                     arg_type=get_three_state_flag(), default=False,
+                     help='Indicates whether to force to execute operation to create \
+                           an existing connection even without any updates.')
+
 def add_target_type_argument(context, source):
     TARGET_TYPES = [
         elem.value for elem in SUPPORTED_AUTH_TYPE.get(source).keys()]
@@ -321,6 +327,7 @@ def load_arguments(self, _):  # pylint: disable=too-many-statements
                 add_customized_keys_argument(c)
                 add_opt_out_argument(c)
                 add_connstr_props_argument(c)
+                add_force_create_arguments(c)
 
             with self.argument_context('{} connection update {}'.format(source.value, target.value)) as c:
                 add_client_type_argument(c, source, target)

src/azure-cli/azure/cli/command_modules/serviceconnector/_utils.py

@@ -573,3 +573,53 @@ def get_aks_resource_name(linker):
 def get_aks_resource_secret_name(connection_name):
     valid_name = re.sub(r'[^a-zA-Z0-9]', '', connection_name, flags=re.IGNORECASE)
     return f'sc-{valid_name}-secret'
+
+
+def compare_properties_changed(new_props, existing_props):
+    """
+    Deep comparison function that checks if there are meaningful differences
+    between new properties and existing properties, ignoring None values.
+    Returns True if there are differences that require an update.
+    """
+    def has_meaningful_changes(new_value, existing_value):
+        if new_value is None:
+            # If new value is None, no change needed
+            return False
+
+        if isinstance(new_value, dict) and isinstance(existing_value, dict):
+            # For nested dictionaries, check each key recursively
+            for key, value in new_value.items():
+                existing_props_key = key
+                if '_' in key:
+                    existing_props_key = to_camel_case(key)
+                existing_nested = existing_value.get(existing_props_key) if existing_value else None
+                if has_meaningful_changes(value, existing_nested):
+                    return True
+            return False
+        elif isinstance(new_value, dict) and existing_value is None:
+            # If existing is None but new is a dict, check if any values in new dict are meaningful
+            for value in new_value.values():
+                if value is not None:
+                    return True
+            return False
+        else:
+            # For primitive values, compare directly
+            return new_value != existing_value
+
+    # Check if any property has meaningful changes
+    for key, new_value in new_props.items():
+        existing_props_key = key
+        if '_' in key:
+            existing_props_key = to_camel_case(key)
+        existing_value = existing_props.get(existing_props_key) if existing_props else None
+        if has_meaningful_changes(new_value, existing_value):
+            return True
+    return False
+
+
+def to_camel_case(snake_str):
+    if not snake_str or '_' not in snake_str:
+        return snake_str
+    components = snake_str.split('_')
+    return components[0] + ''.join(word.capitalize() for word in components[1:])
+

src/azure-cli/azure/cli/command_modules/serviceconnector/custom.py

@@ -31,6 +31,7 @@
 )
 from ._addon_factory import AddonFactory
 from ._utils import (
+    compare_properties_changed,
     set_user_token_by_source_and_target,
     set_user_token_header,
     auto_register,
@@ -317,7 +318,8 @@ def connection_create(cmd, client,  # pylint: disable=too-many-locals,too-many-s
                       target_app_name=None,                                  # Resource.ContainerApp
                       connstr_props=None,                                    # Resource.FabricSql
                       fabric_workspace_uuid=None,
-                      fabric_sql_db_uuid=None
+                      fabric_sql_db_uuid=None,
+                      force=False,
                       ):
     auth_action = 'optOutAllAuth' if (opt_out_list is not None and
                                       OPT_OUT_OPTION.AUTHENTICATION.value in opt_out_list) else None
@@ -370,7 +372,8 @@ def connection_create(cmd, client,  # pylint: disable=too-many-locals,too-many-s
                                   app_config_id=app_config_id,
                                   enable_appconfig_extension=enable_appconfig_extension,
                                   server=server, database=database,
-                                  connstr_props=connstr_props
+                                  connstr_props=connstr_props,
+                                  force=force,
                                   )
 
 
@@ -406,6 +409,7 @@ def connection_create_func(cmd, client,  # pylint: disable=too-many-locals,too-m
                            target_app_name=None,                                  # Resource.ContainerApp
                            enable_appconfig_extension=False,
                            connstr_props=None,                                    # Resource.FabricSql
+                           force=False,
                            **kwargs,
                            ):
     if not source_id:
@@ -530,6 +534,11 @@ def connection_create_func(cmd, client,  # pylint: disable=too-many-locals,too-m
                                      'manually and then create the connection.'.format(str(e)))
 
     validate_service_state(parameters)
+    linker = todict(client.get(resource_uri=source_id, linker_name=connection_name))
+    if (linker is not None and not compare_properties_changed(parameters, linker) and force is False):
+        logger.warning('Connection exists and no property to be updated, skip the update operation. Use --force to force the connection recreation')
+        return linker
+
     if enable_mi_for_db_linker and auth_action != 'optOutAllAuth':
         new_auth_info = enable_mi_for_db_linker(
             cmd, source_id, target_id, auth_info, client_type, connection_name, connstr_props)