[RDBMS] az postgres flexible-server update: add user confirmation on certain update operations

Author: Matthew Boentoro

src/azure-cli/azure/cli/command_modules/rdbms/flexible_server_custom_postgres.py

@@ -345,6 +345,8 @@ def flexible_server_update_custom_func(cmd, client, instance,
                                                        yes=yes)
         instance.network.private_dns_zone_arm_resource_id = private_dns_zone_id
 
+    _confirm_restart_server(instance, sku_name, storage_gb, yes)
+
     if sku_name:
         instance.sku.name = sku_name
 
@@ -1789,6 +1791,27 @@ def _update_login(server_name, resource_group_name, auth_config, password_auth,
     return administrator_login, administrator_login_password
 
 
+# pylint: disable=chained-comparison
+def _confirm_restart_server(instance, sku_name, storage_gb, yes):
+    show_confirmation = False
+
+    # check if sku_name is changed
+    if sku_name and sku_name != instance.sku.name:
+        show_confirmation = True
+
+    # check if storage_gb is exceeding 4096 threshold
+    if storage_gb and storage_gb > 4096 and instance.storage.storage_size_gb <= 4096 and instance.storage.type == "":
+        show_confirmation = True
+
+    # check if storage_gb changed for PremiumV2_LRS
+    if storage_gb and instance.storage.type == "PremiumV2_LRS" and instance.storage.storage_size_gb != storage_gb:
+        show_confirmation = True
+
+    if not yes and show_confirmation:
+        user_confirmation("You are trying to change the compute or the size of storage assigned to your server in a way that \
+            requires a server restart. During the restart, you'll experience some downtime of the server. Do you want to proceed?", yes=yes)
+
+
 # pylint: disable=too-many-instance-attributes, too-few-public-methods
 class DbContext:
     def __init__(self, cmd=None, azure_sdk=None, logging_name=None, cf_firewall=None, cf_db=None,

src/azure-cli/azure/cli/command_modules/rdbms/tests/latest/recordings/test_flexible_server_ssdv2_mgmt.yaml

@@ -164,7 +164,7 @@ def _test_flexible_server_mgmt(self, database_engine, resource_group):
         self.cmd('{} flexible-server update -g {} -n {} -p randompw321##@!'
                  .format(database_engine, resource_group, server_name))
 
-        self.cmd('{} flexible-server update -g {} -n {} --storage-size 256'
+        self.cmd('{} flexible-server update -g {} -n {} --storage-size 256 --yes'
                  .format(database_engine, resource_group, server_name),
                  checks=[JMESPathCheck('storage.storageSizeGb', 256 )])
 
@@ -178,7 +178,7 @@ def _test_flexible_server_mgmt(self, database_engine, resource_group):
 
         tier = 'MemoryOptimized'
         sku_name = memory_optimized_sku
-        self.cmd('{} flexible-server update -g {} -n {} --tier {} --sku-name {}'
+        self.cmd('{} flexible-server update -g {} -n {} --tier {} --sku-name {} --yes'
                  .format(database_engine, resource_group, server_name, tier, sku_name),
                  checks=[JMESPathCheck('sku.tier', tier),
                          JMESPathCheck('sku.name', sku_name)])
@@ -350,7 +350,7 @@ def _test_flexible_server_mgmt_case_insensitive(self, database_engine, resource_
         sku_name = 'Standard_E2ds_v4'
         sku_name_lower = sku_name.lower()
 
-        self.cmd('{} flexible-server update -g {} -n {} --tier {} --sku-name {}'
+        self.cmd('{} flexible-server update -g {} -n {} --tier {} --sku-name {} --yes'
                  .format(database_engine, resource_group, server_name, tier_lower, sku_name_lower),
                  checks=[JMESPathCheck('sku.tier', tier),
                          JMESPathCheck('sku.name', sku_name)])
@@ -407,7 +407,7 @@ def _test_flexible_server_ssdv2_mgmt(self, database_engine, resource_group):
         self.assertEqual(basic_info['backup']['backupRetentionDays'], backup_retention)
 
         # test updates
-        self.cmd('{} flexible-server update -g {} -n {} --storage-size 300'
+        self.cmd('{} flexible-server update -g {} -n {} --storage-size 300 --yes'
                  .format(database_engine, resource_group, server_name),
                  checks=[JMESPathCheck('storage.storageSizeGb', 300 )])