Skip to content

Commit 0255a9c

Browse files
rbtrjpayne3506
authored andcommitted
fix: add OS=windows to manifest-add args (#2194)
due to a change in buildx, we need to explicitly pull the windows variant of the windows image that we have previously built. Signed-off-by: Evan Baker <[email protected]>
1 parent 37beeb7 commit 0255a9c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -478,14 +478,14 @@ manifest-create:
478478
$(CONTAINER_BUILDER) manifest create $(IMAGE_REGISTRY)/$(IMAGE):$(TAG)
479479

480480
manifest-add:
481-
$(CONTAINER_BUILDER) manifest add --os-version=$($(OS_VERSION)) $(IMAGE_REGISTRY)/$(IMAGE):$(TAG) docker://$(IMAGE_REGISTRY)/$(IMAGE):$(subst /,-,$(PLATFORM))$(if $(OS_VERSION),-$(OS_VERSION),)-$(TAG)
481+
$(CONTAINER_BUILDER) manifest add --os=$(OS) --os-version=$($(OS_VERSION)) $(IMAGE_REGISTRY)/$(IMAGE):$(TAG) docker://$(IMAGE_REGISTRY)/$(IMAGE):$(subst /,-,$(PLATFORM))$(if $(OS_VERSION),-$(OS_VERSION),)-$(TAG)
482482

483483
manifest-build: # util target to compose multiarch container manifests from platform specific images.
484484
$(MAKE) manifest-create
485485
$(foreach PLATFORM,$(PLATFORMS),\
486486
$(if $(filter $(PLATFORM),windows/amd64),\
487487
$(foreach OS_VERSION,$(OS_VERSIONS),\
488-
$(MAKE) manifest-add OS_VERSION=$(OS_VERSION) PLATFORM=$(PLATFORM);\
488+
$(MAKE) manifest-add CONTAINER_BUILDER=$(CONTAINER_BUILDER) OS=windows OS_VERSION=$(OS_VERSION) PLATFORM=$(PLATFORM);\
489489
),\
490490
$(MAKE) manifest-add PLATFORM=$(PLATFORM);\
491491
)\

0 commit comments

Comments
 (0)