feat: fix lint

Author: BeegiiK

aitelemetry/connection_string_parser.go

@@ -8,11 +8,11 @@ import (
 
 type connectionVars struct {
 	instrumentationKey string
-	ingestionUrl       string
+	ingestionURL       string
 }
 
 func (c *connectionVars) String() string {
-	return "InstrumentationKey=" + c.instrumentationKey + ";IngestionEndpoint=" + c.ingestionUrl
+	return "InstrumentationKey=" + c.instrumentationKey + ";IngestionEndpoint=" + c.ingestionURL
 }
 
 func parseConnectionString(connectionString string) (*connectionVars, error) {
@@ -39,12 +39,12 @@ func parseConnectionString(connectionString string) (*connectionVars, error) {
 			connectionVars.instrumentationKey = value
 		case "ingestionendpoint":
 			if value != "" {
-				connectionVars.ingestionUrl = value + "v2.1/track"
+				connectionVars.ingestionURL = value + "v2.1/track"
 			}
 		}
 	}
 
-	if connectionVars.instrumentationKey == "" || connectionVars.ingestionUrl == "" {
+	if connectionVars.instrumentationKey == "" || connectionVars.ingestionURL == "" {
 		return nil, errors.Errorf("missing required fields in connection string: %s", connectionVars)
 	}
 

aitelemetry/connection_string_parser_test.go

@@ -6,7 +6,7 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-const connectionString = "InstrumentationKey=00000000-0000-0000-0000-000000000000;IngestionEndpoint=https://ingestion.endpoint.com/;LiveEndpoint=https://live.endpoint.com/;ApplicationId=11111111-1111-1111-1111-111111111111"
+const connectionString = "InstrumentationKey=0000-0000-0000-0000-0000;IngestionEndpoint=https://ingestion.endpoint.com/;LiveEndpoint=https://live.endpoint.com/;ApplicationId=1111-1111-1111-1111-1111"
 
 func TestParseConnectionString(t *testing.T) {
 	tests := []struct {
@@ -19,8 +19,8 @@ func TestParseConnectionString(t *testing.T) {
 			name:             "Valid connection string and instrumentation key",
 			connectionString: connectionString,
 			want: &connectionVars{
-				instrumentationKey: "00000000-0000-0000-0000-000000000000",
-				ingestionUrl:       "https://ingestion.endpoint.com/v2.1/track",
+				instrumentationKey: "0000-0000-0000-0000-0000",
+				ingestionURL:       "https://ingestion.endpoint.com/v2.1/track",
 			},
 			wantErr: false,
 		},
@@ -32,7 +32,7 @@ func TestParseConnectionString(t *testing.T) {
 		},
 		{
 			name:             "Valid instrumentation key with missing ingestion endpoint",
-			connectionString: "InstrumentationKey=00000000-0000-0000-0000-000000000000;IngestionEndpoint=",
+			connectionString: "InstrumentationKey=0000-0000-0000-0000-0000;IngestionEndpoint=",
 			want:             nil,
 			wantErr:          true,
 		},
@@ -59,7 +59,7 @@ func TestParseConnectionString(t *testing.T) {
 				require.NoError(t, err, "Expected no error but got one")
 				require.NotNil(t, got, "Expected a non-nil result")
 				require.Equal(t, tt.want.instrumentationKey, got.instrumentationKey, "Instrumentation Key does not match")
-				require.Equal(t, tt.want.ingestionUrl, got.ingestionUrl, "Ingestion URL does not match")
+				require.Equal(t, tt.want.ingestionURL, got.ingestionURL, "Ingestion URL does not match")
 			}
 		})
 	}

aitelemetry/telemetrywrapper.go

@@ -162,7 +162,7 @@ func isPublicEnvironment(url string, retryCount, waitTimeInSecs int) (bool, erro
 			return true, nil
 		} else if err == nil {
 			debugLog("[AppInsights] This is not azure public cloud:%s", cloudName)
-			return false, fmt.Errorf("not an azure public cloud: %s", cloudName)
+			return false, errors.Errorf("not an azure public cloud: %s", cloudName)
 		}
 
 		debugLog("GetAzureCloud returned err :%v", err)
@@ -233,7 +233,7 @@ func NewWithConnectionString(connectionString string, aiConfig AIConfig) (Teleme
 	}
 
 	telemetryConfig := appinsights.NewTelemetryConfiguration(connectionVars.instrumentationKey)
-	telemetryConfig.EndpointUrl = connectionVars.ingestionUrl
+	telemetryConfig.EndpointUrl = connectionVars.ingestionURL
 	telemetryConfig.MaxBatchSize = aiConfig.BatchSize
 	telemetryConfig.MaxBatchInterval = time.Duration(aiConfig.BatchInterval) * time.Second
 

aitelemetry/telemetrywrapper_test.go

@@ -87,7 +87,7 @@ func handleGetCloud(w http.ResponseWriter, req *http.Request) {
 	w.Write([]byte(getCloudResponse))
 }
 
-func initTelemetry(t *testing.T) (TelemetryHandle, TelemetryHandle) {
+func initTelemetry(_ *testing.T) (th1, th2 TelemetryHandle) {
 	th1, err1 := NewAITelemetry(httpURL, "00ca2a73-c8d6-4929-a0c2-cf84545ec225", aiConfig)
 	if err1 != nil {
 		fmt.Printf("Error initializing AI telemetry: %v", err1)
@@ -98,7 +98,7 @@ func initTelemetry(t *testing.T) (TelemetryHandle, TelemetryHandle) {
 		fmt.Printf("Error initializing AI telemetry with connection string: %v", err2)
 	}
 
-	return th1, th2
+	return
 }
 
 func TestEmptyAIKey(t *testing.T) {