Skip to content

Commit 1a0fdb1

Browse files
fix: Address comments, add todo for Evan's feedback
1 parent d14d768 commit 1a0fdb1

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

cns/NetworkContainerContract.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,10 @@ const (
5555
JobObject = "JobObject"
5656
COW = "COW" // Container on Windows
5757
BackendNICNC = "BackendNICNC"
58-
NodeSubnet = "NodeSubnet" // Artificial Container Type for NodeSubnet
5958
)
6059

60+
const NodeSubnet = "NodeSubnet" // Artificial Container Type for NodeSubnet
61+
6162
// Orchestrator Types
6263
const (
6364
Kubernetes = "Kubernetes"

cns/restserver/internalapi.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -405,6 +405,8 @@ func (service *HTTPRestService) ReconcileIPAMStateForSwift(ncReqs []*cns.CreateN
405405
return types.Success
406406
}
407407

408+
// todo: there is some redundancy between this funcation and ReconcileIPAMStateForNodeSubnet. The difference is that this one
409+
// doesn't include the NNC parameter. We may want to unify the common parts.
408410
func (service *HTTPRestService) ReconcileIPAMStateForNodeSubnet(ncReqs []*cns.CreateNetworkContainerRequest, podInfoByIP map[string]cns.PodInfo) types.ResponseCode {
409411
logger.Printf("Reconciling CNS IPAM state with nc requests: [%+v], PodInfo [%+v]", ncReqs, podInfoByIP)
410412

0 commit comments

Comments
 (0)