Remove GetNCVersionURLFmt from NodeInfo contract (#718)

This change removes GetNCVersionURLFmt from the NodeInfoResponse which CNS gets
as a part of SyncNodeStatus in case of managed mode. This data is available with CNS and
should not be needed from DNC.

Author: ashvindeodhar

cns/NetworkContainerContract.go

@@ -373,6 +373,5 @@ func (networkContainerRequestPolicy *NetworkContainerRequestPolicies) Validate()
 
 // NodeInfoResponse - Struct to hold the node info response.
 type NodeInfoResponse struct {
-	NetworkContainers  []CreateNetworkContainerRequest
-	GetNCVersionURLFmt string
+	NetworkContainers []CreateNetworkContainerRequest
 }

cns/restserver/internalapi.go

@@ -93,7 +93,7 @@ func (service *HTTPRestService) SyncNodeStatus(dncEP, infraVnet, nodeID string,
 	// check if the version is valid and save it to service state
 	for ncid, nc := range ncsToBeAdded {
 		var (
-			versionURL = fmt.Sprintf(nodeInfoResponse.GetNCVersionURLFmt,
+			versionURL = fmt.Sprintf(nmagentclient.GetNetworkContainerVersionURLFmt,
 				nmagentclient.WireserverIP,
 				nc.PrimaryInterfaceIdentifier,
 				nc.NetworkContainerid,