fix: lint

Author: santhoshmprabhu

bpf-prog/azure-block-iptables/cmd/azure-block-iptables/main.go

@@ -14,7 +14,11 @@ import (
 )
 
 // ProgramVersion is set during build
-var version = "unknown"
+var (
+	version         = "unknown"
+	ErrModeRequired = errors.New("mode is required")
+	ErrInvalidMode  = errors.New("invalid mode. Use -mode=attach or -mode=detach")
+)
 
 // Config holds configuration for the application
 type Config struct {
@@ -45,11 +49,11 @@ func parseArgs() (*Config, error) {
 	}
 
 	if *mode == "" {
-		return nil, fmt.Errorf("mode is required. Use -mode=attach or -mode=detach")
+		return nil, ErrModeRequired
 	}
 
 	if *mode != "attach" && *mode != "detach" {
-		return nil, fmt.Errorf("invalid mode '%s'. Must be 'attach' or 'detach'", *mode)
+		return nil, ErrInvalidMode
 	}
 
 	return &Config{
@@ -107,7 +111,7 @@ func run(config *Config) error {
 	case "detach":
 		return detachMode(config)
 	default:
-		return fmt.Errorf("unsupported mode: %s", config.Mode)
+		return ErrInvalidMode
 	}
 }
 

bpf-prog/azure-block-iptables/cmd/azure-block-iptables/main_test.go

@@ -49,7 +49,9 @@ func TestHandleFileEventWithMock(t *testing.T) {
 			// Reset mock state
 			mockAttacher.Reset()
 
-			run(&Config{Mode: tc.mode, Overwrite: tc.overwrite, AttacherFactory: func() bpfprogram.Attacher { return mockAttacher }})
+			if err := run(&Config{Mode: tc.mode, Overwrite: tc.overwrite, AttacherFactory: func() bpfprogram.Attacher { return mockAttacher }}); err != nil {
+				t.Errorf("Failed to run: %v", err)
+			}
 
 			// Verify expectations
 			if mockAttacher.AttachCallCount() != tc.expectedAttach {

bpf-prog/azure-block-iptables/pkg/bpfprogram/program.go

@@ -188,7 +188,12 @@ func (p *Program) Attach() error {
 		}
 
 		pinPath := filepath.Join(BPFMapPinPath, IptablesLegacyBlockProgramName)
-		l.Pin(pinPath)
+		err = l.Pin(pinPath)
+		if err != nil {
+			l.Close()
+			return errors.Wrap(err, "failed to pin iptables_legacy_block LSM")
+		}
+
 		links = append(links, l)
 	}
 
@@ -208,7 +213,16 @@ func (p *Program) Attach() error {
 			return errors.Wrap(err, "failed to attach block_nf_netlink LSM")
 		}
 		pinPath := filepath.Join(BPFMapPinPath, IptablesNftablesBlockProgramName)
-		l.Pin(pinPath)
+		err = l.Pin(pinPath)
+		if err != nil {
+			for _, link := range links {
+				link.Close()
+			}
+
+			l.Close()
+			return errors.Wrap(err, "failed to pin iptables_nftables_block LSM")
+		}
+
 		links = append(links, l)
 	}