Skip to content

Commit 3f313ad

Browse files
authored
fix: add OS=windows to manifest-add args (#2194)
due to a change in buildx, we need to explicitly pull the windows variant of the windows image that we have previously built. Signed-off-by: Evan Baker <[email protected]>
1 parent 0b743ac commit 3f313ad

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -480,14 +480,14 @@ manifest-create:
480480
$(CONTAINER_BUILDER) manifest create $(IMAGE_REGISTRY)/$(IMAGE):$(TAG)
481481

482482
manifest-add:
483-
$(CONTAINER_BUILDER) manifest add --os-version=$($(OS_VERSION)) $(IMAGE_REGISTRY)/$(IMAGE):$(TAG) docker://$(IMAGE_REGISTRY)/$(IMAGE):$(subst /,-,$(PLATFORM))$(if $(OS_VERSION),-$(OS_VERSION),)-$(TAG)
483+
$(CONTAINER_BUILDER) manifest add --os=$(OS) --os-version=$($(OS_VERSION)) $(IMAGE_REGISTRY)/$(IMAGE):$(TAG) docker://$(IMAGE_REGISTRY)/$(IMAGE):$(subst /,-,$(PLATFORM))$(if $(OS_VERSION),-$(OS_VERSION),)-$(TAG)
484484

485485
manifest-build: # util target to compose multiarch container manifests from platform specific images.
486486
$(MAKE) manifest-create
487487
$(foreach PLATFORM,$(PLATFORMS),\
488488
$(if $(filter $(PLATFORM),windows/amd64),\
489489
$(foreach OS_VERSION,$(OS_VERSIONS),\
490-
$(MAKE) manifest-add OS_VERSION=$(OS_VERSION) PLATFORM=$(PLATFORM);\
490+
$(MAKE) manifest-add CONTAINER_BUILDER=$(CONTAINER_BUILDER) OS=windows OS_VERSION=$(OS_VERSION) PLATFORM=$(PLATFORM);\
491491
),\
492492
$(MAKE) manifest-add PLATFORM=$(PLATFORM);\
493493
)\

0 commit comments

Comments
 (0)