Skip to content

Commit 413f253

Browse files
committed
addressed comments on PR
1 parent cae983b commit 413f253

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

hack/aks/Makefile

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ VM_SIZE ?= Standard_B2s
2121
VM_SIZE_WIN ?= Standard_B2s
2222
IP_TAG ?= FirstPartyUsage=/DelegatedNetworkControllerTest
2323
IP_PREFIX ?= serviceTaggedIp
24-
PUBLIC_IPv4 ?= $(IP_PREFIX)-$(CLUSTER)-v4
25-
PUBLIC_IPv6 ?= $(IP_PREFIX)-$(CLUSTER)-v6
24+
PUBLIC_IPv4 ?= $(IP_PREFIX)-$(CLUSTER)-v4
25+
PUBLIC_IPv6 ?= $(IP_PREFIX)-$(CLUSTER)-v6
2626
KUBE_PROXY_JSON_PATH ?= ./kube-proxy.json
2727

2828
# overrideable variables
@@ -46,7 +46,7 @@ azcfg: ## Set the $AZCLI to use aks-preview
4646
@$(AZCLI) extension add --name aks-preview --yes
4747
@$(AZCLI) extension update --name aks-preview
4848

49-
public-ipv4: rg-up
49+
public-ipv4:
5050
$(AZCLI) network public-ip create --name $(PUBLIC_IPv4) \
5151
--resource-group $(GROUP) \
5252
--allocation-method Static \
@@ -56,7 +56,7 @@ public-ipv4: rg-up
5656
--tier Regional \
5757
--version IPv4
5858

59-
public-ipv6: rg-up
59+
public-ipv6:
6060
$(AZCLI) network public-ip create --name $(PUBLIC_IPv6) \
6161
--resource-group $(GROUP) \
6262
--allocation-method Static \
@@ -127,7 +127,6 @@ nodesubnet-byocni-nokubeproxy-up: rg-up overlay-net-up ## Brings up an NodeSubne
127127
--kubernetes-version $(K8S_VER) \
128128
--node-count $(NODE_COUNT) \
129129
--node-vm-size $(VM_SIZE) \
130-
--load-balancer-sku standard \
131130
--max-pods 250 \
132131
--load-balancer-outbound-ips /subscriptions/$(SUB)/resourceGroups/$(GROUP)/providers/Microsoft.Network/publicIPAddresses/$(PUBLIC_IPv4) \
133132
--network-plugin none \

0 commit comments

Comments
 (0)