fix: save cni state only during endpoint creation or deletion (#3254)

* save only during endpoint creation or deletion

* backport retry pool allocation after cleaning IPAM state

Author: QxBytes

cni/network/invoker_azure.go

@@ -56,6 +56,8 @@ func (invoker *AzureIPAMInvoker) Add(addConfig IPAMAddConfig) (IPAMAddResult, er
 
 	if err != nil && strings.Contains(err.Error(), ipam.ErrNoAvailableAddressPools.Error()) {
 		invoker.deleteIpamState()
+		log.Printf("Retry pool allocation after deleting IPAM state")
+		addResult.ipv4Result, err = invoker.plugin.DelegateAdd(addConfig.nwCfg.IPAM.Type, addConfig.nwCfg)
 	}
 	if err != nil {
 		err = invoker.plugin.Errorf("Failed to allocate pool: %v", err)

network/manager.go

@@ -250,11 +250,6 @@ func (nm *networkManager) AddExternalInterface(ifName string, subnet string) err
 		return err
 	}
 
-	err = nm.save()
-	if err != nil {
-		return err
-	}
-
 	return nil
 }
 
@@ -268,11 +263,6 @@ func (nm *networkManager) CreateNetwork(nwInfo *NetworkInfo) error {
 		return err
 	}
 
-	err = nm.save()
-	if err != nil {
-		return err
-	}
-
 	return nil
 }