Skip to content

Commit 52b8247

Browse files
committed
add non noisy logs back
1 parent 34c3aea commit 52b8247

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

npm/pkg/dataplane/dataplane.go

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,7 @@ type DataPlane struct {
8181
func NewDataPlane(nodeName string, ioShim *common.IOShim, cfg *Config, stopChannel <-chan struct{}) (*DataPlane, error) {
8282
metrics.InitializeAll()
8383
if util.IsWindowsDP() {
84-
// TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level
85-
// klog.Infof("[DataPlane] enabling AddEmptySetToLists for Windows")
84+
klog.Infof("[DataPlane] enabling AddEmptySetToLists for Windows")
8685
cfg.IPSetManagerCfg.AddEmptySetToLists = true
8786
}
8887

@@ -107,15 +106,13 @@ func NewDataPlane(nodeName string, ioShim *common.IOShim, cfg *Config, stopChann
107106
// do not let Linux apply in background
108107
dp.applyInBackground = cfg.ApplyInBackground && util.IsWindowsDP()
109108
if dp.applyInBackground {
110-
// TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level
111-
// klog.Infof("[DataPlane] dataplane configured to apply in background every %v or every %d calls to ApplyDataPlane()", dp.ApplyInterval, dp.ApplyMaxBatches)
109+
klog.Infof("[DataPlane] dataplane configured to apply in background every %v or every %d calls to ApplyDataPlane()", dp.ApplyInterval, dp.ApplyMaxBatches)
112110
dp.updatePodCache = newUpdatePodCache(cfg.ApplyMaxBatches)
113111
if dp.ApplyMaxBatches <= 0 || dp.ApplyInterval == 0 {
114112
return nil, ErrInvalidApplyConfig
115113
}
116114
} else {
117-
// TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level
118-
// klog.Info("[DataPlane] dataplane configured to NOT apply in background")
115+
klog.Info("[DataPlane] dataplane configured to NOT apply in background")
119116
dp.updatePodCache = newUpdatePodCache(1)
120117
}
121118

@@ -153,8 +150,7 @@ func (dp *DataPlane) FinishBootupPhase() {
153150
dp.applyInfo.Lock()
154151
defer dp.applyInfo.Unlock()
155152

156-
// TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level
157-
// klog.Infof("[DataPlane] finished bootup phase")
153+
klog.Infof("[DataPlane] finished bootup phase")
158154
dp.applyInfo.inBootupPhase = false
159155
}
160156

0 commit comments

Comments
 (0)