fixed golint

Author: rejain789

cns/middlewares/k8sSwiftV2.go

@@ -66,12 +66,12 @@ func (k *K8sSWIFTv2Middleware) IPConfigsRequestHandlerWrapper(defaultHandler, fa
 			var defaultDenyEngressPolicy, defaultDenyIngressPolicy policy.Policy
 
 			if defaultDenyACLbool && ipInfo.NICType == cns.InfraNIC {
-				defaultDenyEngressPolicy, err = getEndpointPolicyL(string(policy.ACLPolicy), cns.ActionTypeBlock, cns.DirectionTypeOut, 10_000)
+				defaultDenyEngressPolicy, err = getEndpointPolicy(string(policy.ACLPolicy), cns.ActionTypeBlock, cns.DirectionTypeOut, 10_000)
 				if err != nil {
 					logger.Errorf("failed to add default deny acl's for pod %v with err %v", podInfo.Name(), err)
 				}
 
-				defaultDenyIngressPolicy, err = getEndpointPolicyL(string(policy.ACLPolicy), cns.ActionTypeBlock, cns.DirectionTypeIn, 10_000)
+				defaultDenyIngressPolicy, err = getEndpointPolicy(string(policy.ACLPolicy), cns.ActionTypeBlock, cns.DirectionTypeIn, 10_000)
 				if err != nil {
 					logger.Errorf("failed to add default deny acl's for pod %v with err %v", podInfo.Name(), err)
 				}

cns/middlewares/k8sSwiftV2_linux.go

@@ -105,6 +105,6 @@ func (k *K8sSWIFTv2Middleware) assignSubnetPrefixLengthFields(_ *cns.PodIpInfo,
 
 func (k *K8sSWIFTv2Middleware) addDefaultRoute(*cns.PodIpInfo, string) {}
 
-func getEndpointPolicyL(_, _, _ string, _ int) (policy.Policy, error) {
+func getEndpointPolicy(_, _, _ string, _ int) (policy.Policy, error) {
 	return policy.Policy{}, nil
 }

cns/middlewares/k8sSwiftV2_windows.go

@@ -63,7 +63,7 @@ func (k *K8sSWIFTv2Middleware) addDefaultRoute(podIPInfo *cns.PodIpInfo, gwIP st
 }
 
 // get policy of type endpoint policy given the params
-func getEndpointPolicyL(policyType, action, direction string, priority int) (policy.Policy, error) {
+func getEndpointPolicy(policyType, action, direction string, priority int) (policy.Policy, error) {
 	endpointPolicy, err := createEndpointPolicy(policyType, action, direction, priority)
 	if err != nil {
 		return policy.Policy{}, errors.Wrap(err, "failed to create endpoint policy")
@@ -78,7 +78,7 @@ func getEndpointPolicyL(policyType, action, direction string, priority int) (pol
 }
 
 // create policy given the params
-func createEndpointPolicy(policyType string, action string, direction string, priority int) ([]byte, error) {
+func createEndpointPolicy(policyType, action, direction string, priority int) ([]byte, error) {
 	type EndpointPolicy struct {
 		Type      string `json:"Type"`
 		Action    string `json:"Action"`

cns/middlewares/k8sSwiftV2_windows_test.go

@@ -149,8 +149,14 @@ func TestAddDefaultDenyACL(t *testing.T) {
 	var allEndpoints []policy.Policy
 	var defaultDenyEngressPolicy, defaultDenyIngressPolicy policy.Policy
 	var err error
-	defaultDenyEngressPolicy, err = getEndpointPolicyL("ACL", "Block", "Out", 10000)
-	defaultDenyIngressPolicy, err = getEndpointPolicyL("ACL", "Block", "In", 10000)
+	defaultDenyEngressPolicy, err = getEndpointPolicy("ACL", "Block", "Out", 10_000)
+	if err != nil {
+		fmt.Printf("failed to create endpoint policy")
+	}
+	defaultDenyIngressPolicy, err = getEndpointPolicy("ACL", "Block", "In", 10_000)
+	if err != nil {
+		fmt.Printf("failed to create endpoint policy")
+	}
 
 	allEndpoints = append(allEndpoints, defaultDenyEngressPolicy, defaultDenyIngressPolicy)
 	assert.Equal(t, err, nil)