more TODOs

Author: rjdenney

cns/kubecontroller/nodenetworkconfig/conversion_linux.go

@@ -18,17 +18,23 @@ func createNCRequestFromStaticNCHelper(nc v1alpha.NetworkContainer, primaryIPPre
 
 	// iterate through all IP addresses in the subnet described by primaryPrefix and
 	// add them to the request as secondary IPConfigs.
+	// TODO: If we decide to look to not change the contract to add an IPFamilies flag and just detect it we would have to do it here
+	// By doing this we can also have it work for Dualstack Overlay
+	// To do it we would need to pass in a pointer to an IPFamilies slice to this function and add the family of the IPs added in
+	// Here we check the primary CIDR which is needed for overlay and VNET Block
 	for addr := primaryIPPrefix.Masked().Addr(); primaryIPPrefix.Contains(addr); addr = addr.Next() {
 		secondaryIPConfigs[addr.String()] = cns.SecondaryIPConfig{
 			IPAddress: addr.String(),
 			NCVersion: int(nc.Version),
 		}
+
 	}
 
 	// Add IPs from CIDR block to the secondary IPConfigs
 	if nc.Type == v1alpha.VNETBlock {
 
 		for _, ipAssignment := range nc.IPAssignments {
+			// Here we would need to check all other assigned CIDR Blocks that aren't the primary.
 			cidrPrefix, err := netip.ParsePrefix(ipAssignment.IP)
 			if err != nil {
 				return nil, errors.Wrapf(err, "invalid CIDR block: %s", ipAssignment.IP)

cns/middlewares/k8sSwiftV2.go

@@ -38,7 +38,7 @@ var _ cns.IPConfigsHandlerMiddleware = (*K8sSWIFTv2Middleware)(nil)
 
 // IPConfigsRequestHandlerWrapper is the middleware function for handling SWIFT v2 IP configs requests for AKS-SWIFT. This function wrapped the default SWIFT request
 // and release IP configs handlers.
-// this will need to change to also work for a delegated NIC with multiple IPs
+// TODO: this will need to changed or add a new function to also work for a delegated NIC with multiple pods
 func (k *K8sSWIFTv2Middleware) IPConfigsRequestHandlerWrapper(defaultHandler, failureHandler cns.IPConfigsHandlerFunc) cns.IPConfigsHandlerFunc {
 	return func(ctx context.Context, req cns.IPConfigsRequest) (*cns.IPConfigsResponse, error) {
 		podInfo, respCode, message := k.validateIPConfigsRequest(ctx, &req)

cns/middlewares/k8sSwiftV2_linux.go

@@ -18,6 +18,9 @@ func (k *K8sSWIFTv2Middleware) setRoutes(podIPInfo *cns.PodIpInfo) error {
 	var routes []cns.Route
 
 	switch podIPInfo.NICType {
+	// TODO: We may want to create a new type of NIC. Currently we are using delegated NICs but this set routes method only
+	// takes in for the multitenant scenario. We should have a new case that behaves similarly to InfraNIC but for a delegated NIC
+	// Q: Does the code currently see the kube pods as Infra or Delegated? They currently use the delegated pod subnet for IPs
 	case cns.DelegatedVMNIC:
 		virtualGWRoute := cns.Route{
 			IPAddress: fmt.Sprintf("%s/%d", virtualGW, prefixLength),
@@ -65,6 +68,7 @@ func (k *K8sSWIFTv2Middleware) setRoutes(podIPInfo *cns.PodIpInfo) error {
 			return errors.Wrapf(err, "failed to parse podIPConfig IP address %s", podIPInfo.PodIPConfig.IPAddress)
 		}
 
+		//This function is called per IP so we shouldn't have to worry about adding both v4 and v6 at once
 		if ip.Is4() {
 			routes = append(routes, addRoutes(podCIDRsV4, overlayGatewayv4)...)
 			routes = append(routes, addRoutes(serviceCIDRsV4, overlayGatewayv4)...)

cns/middlewares/k8sSwiftV2_windows.go

@@ -20,6 +20,8 @@ func (k *K8sSWIFTv2Middleware) setRoutes(podIPInfo *cns.PodIpInfo) error {
 
 // assignSubnetPrefixLengthFields will assign the subnet-prefix length to some fields of podipinfo
 // this is required for the windows scenario so that HNS programming is successful for pods
+// TODO: This is being used for the delegated NIC for Windows solution. Once we are testing Windows we will
+// Need to confirm that this assigns the whole pod subnet that we expect for both v4 and v6
 func (k *K8sSWIFTv2Middleware) assignSubnetPrefixLengthFields(podIPInfo *cns.PodIpInfo, interfaceInfo v1alpha1.InterfaceInfo, ip string) error {
 	// Parse MTPNC SubnetAddressSpace to get the subnet prefix length
 	subnet, subnetPrefix, err := utils.ParseIPAndPrefix(interfaceInfo.SubnetAddressSpace)