fix: remove HNS restart

Signed-off-by: Evan Baker <[email protected]>

Author: rbtr

platform/os_windows.go

@@ -21,8 +21,6 @@ import (
 	"go.uber.org/zap"
 	"golang.org/x/sys/windows"
 	"golang.org/x/sys/windows/registry"
-	"golang.org/x/sys/windows/svc"
-	"golang.org/x/sys/windows/svc/mgr"
 )
 
 const (
@@ -251,10 +249,6 @@ func SetSdnRemoteArpMacAddress(ctx context.Context) error {
 		return err
 	}
 	log.Printf("SDNRemoteArpMacAddress regKey set successfully")
-	if err := restartHNS(ctx); err != nil {
-		return err
-	}
-	log.Printf("HNS service restarted successfully")
 	return nil
 }
 
@@ -280,49 +274,6 @@ func setSDNRemoteARPRegKey() error {
 	return nil
 }
 
-func restartHNS(ctx context.Context) error {
-	log.Printf("Restarting HNS service")
-	// connect to the service manager
-	m, err := mgr.Connect()
-	if err != nil {
-		return errors.Wrap(err, "could not connect to service manager")
-	}
-	defer m.Disconnect() //nolint:errcheck // ignore error
-	// open the HNS service
-	service, err := m.OpenService("hns")
-	if err != nil {
-		return errors.Wrap(err, "could not access service")
-	}
-	defer service.Close()
-	// Stop the service
-	_, err = service.Control(svc.Stop)
-	if err != nil {
-		return errors.Wrap(err, "could not stop service")
-	}
-	// Wait for the service to stop
-	ticker := time.NewTicker(500 * time.Millisecond) //nolint:gomnd // 500ms
-	defer ticker.Stop()
-	for { // hacky cancellable do-while
-		status, err := service.Query()
-		if err != nil {
-			return errors.Wrap(err, "could not query service status")
-		}
-		if status.State == svc.Stopped {
-			break
-		}
-		select {
-		case <-ctx.Done():
-			return errors.New("context cancelled")
-		case <-ticker.C:
-		}
-	}
-	// Start the service again
-	if err := service.Start(); err != nil {
-		return errors.Wrap(err, "could not start service")
-	}
-	return nil
-}
-
 func HasMellanoxAdapter() bool {
 	m := &mellanox.Mellanox{}
 	return hasNetworkAdapter(m)