chore: address todo items in cilium e2e templates (#3675)

* chore: address todo remove repeated validate pods check

* chore: address todo delete echo-external-node deployment and deleting connectivity test resources

* delete deployment

Author: camrynl

.pipelines/singletenancy/cilium-dualstack-overlay/cilium-dualstackoverlay-e2e-step-template.yaml

@@ -133,9 +133,6 @@ steps:
   - script: |
       echo "validate pod IP assignment and check systemd-networkd restart"
       kubectl get pod -owide -A
-      # Deleting echo-external-node deployment until cilium version matches TODO. https://github.com/cilium/cilium-cli/issues/67 is addressing the change.
-      # Saves 17 minutes
-      kubectl delete deploy -n $(ciliumNamespace) echo-external-node
       cd test/integration/load
       CNI_TYPE=cilium_dualstack go test -timeout 30m -tags load -run ^TestValidateState$
       echo "delete cilium connectivity test resources and re-validate state"

.pipelines/singletenancy/cilium-overlay-withhubble/cilium-overlay-e2e-step-template.yaml

@@ -148,10 +148,6 @@ steps:
         kubectl get ciliumidentity | grep cilium-test
       fi
       make test-validate-state
-      echo "delete cilium connectivity test resources and re-validate state" # TODO Delete this and the next 4 lines if connectivity no longer has bug
-      kubectl delete ns $(ciliumNamespace)
-      kubectl get pod -owide -A
-      make test-validate-state
     name: "validatePods"
     displayName: "Validate Pods"
 

.pipelines/singletenancy/cilium-overlay/cilium-overlay-e2e-step-template.yaml

@@ -214,20 +214,6 @@ steps:
     name: "CiliumIdentities"
     displayName: "Verify Cilium Identities Deletion"
 
-  - script: | # TODO REMOVE THIS STEP, make test-load covers this
-      set -e
-      echo "validate pod IP assignment before CNS restart"
-      kubectl get pod -owide -A
-      make test-validate-state
-      echo "restart CNS"
-      kubectl rollout restart ds azure-cns -n kube-system
-      kubectl rollout status ds azure-cns -n kube-system
-      kubectl get pod -owide -A
-      echo "validate pods after CNS restart"
-      make test-validate-state
-    name: "restartCNS"
-    displayName: "Restart CNS and validate pods"
-
   - script: |
       echo "Run wireserver and metadata connectivity Tests"
       bash test/network/wireserver_metadata_test.sh

.pipelines/templates/cilium-tests.yaml

@@ -62,10 +62,6 @@ steps:
       echo "validate pod IP assignment and check systemd-networkd restart"
       kubectl get pod -owide -A
       make test-validate-state
-      echo "delete cilium connectivity test resources and re-validate state" # TODO Delete this and the next 4 lines if connectivity no longer has bug
-      kubectl delete ns $(ciliumNamespace)
-      kubectl get pod -owide -A
-      make test-validate-state
     name: "validatePods"
     displayName: "Validate Pods"