resolved comments

Author: rayaisaiah

npm/pkg/dataplane/dataplane.go

@@ -105,6 +105,7 @@ func NewDataPlane(nodeName string, ioShim *common.IOShim, cfg *Config, stopChann
 	// do not let Linux apply in background
 	dp.applyInBackground = cfg.ApplyInBackground && util.IsWindowsDP()
 	if dp.applyInBackground {
+		klog.Infof("[DataPlane] dataplane configured to apply in background every %v or every %d calls to ApplyDataPlane()", dp.ApplyInterval, dp.ApplyMaxBatches)
 		dp.updatePodCache = newUpdatePodCache(cfg.ApplyMaxBatches)
 		if dp.ApplyMaxBatches <= 0 || dp.ApplyInterval == 0 {
 			return nil, ErrInvalidApplyConfig
@@ -416,6 +417,7 @@ func (dp *DataPlane) addPoliciesWithRetry(context string) {
 		return
 	}
 
+	klog.Errorf("[DataPlane] [%s] failed to add policies. will retry one policy at a time. err: %s", context, err.Error())
 	metrics.SendErrorLogAndMetric(util.DaemonDataplaneID, "[DataPlane] [%s] failed to add policies. err: %s", context, err.Error())
 
 	// retry one policy at a time
@@ -476,6 +478,7 @@ func (dp *DataPlane) addPolicies(netPols []*policies.NPMNetworkPolicy) error {
 		// Create and add references for Selector IPSets first
 		err := dp.createIPSetsAndReferences(netPol.AllPodSelectorIPSets(), netPol.PolicyKey, ipsets.SelectorType)
 		if err != nil {
+			klog.Infof("[DataPlane] error while adding Selector IPSet references: %s", err.Error())
 			return fmt.Errorf("[DataPlane] error while adding Selector IPSet references: %w", err)
 		}
 

npm/pkg/dataplane/types.go

@@ -7,6 +7,7 @@ import (
 	"github.com/Azure/azure-container-networking/npm/pkg/dataplane/ipsets"
 	"github.com/Azure/azure-container-networking/npm/pkg/dataplane/policies"
 	"github.com/Azure/azure-container-networking/npm/util"
+	"k8s.io/klog"
 )
 
 type GenericDataplane interface {
@@ -123,6 +124,7 @@ func (c *updatePodCache) enqueue(m *PodMetadata) *updateNPMPod {
 		// Currently, don't expect this path to be taken because dataplane makes sure to only enqueue on-node Pods.
 		// If the pod is already in the cache but the node name has changed, we need to requeue it.
 		// Can discard the old Pod info since the Pod must have been deleted and brought back up on a different node.
+		klog.Infof("[DataPlane] pod already in cache but node name has changed. deleting the old pod object from the queue. podKey: %s", m.PodKey)
 
 		// remove the old pod from the cache and queue
 		delete(c.cache, m.PodKey)