final cleanup

Author: paulgmiller

cns/healthserver/healthz.go

@@ -70,7 +70,6 @@ func NewHealthzHandlerWithChecks(cfg *Config) (http.Handler, error) {
 			return nil
 		}
 	}
-
 	return &healthz.Handler{
 		Checks: checks,
 	}, nil

cns/restserver/nodesubnet.go

@@ -29,9 +29,7 @@ func (service *HTTPRestService) UpdateIPsForNodeSubnet(secondaryIPs []netip.Addr
 
 	logger.Debugf("IP change processed successfully")
 
-	// saved NC successfully. UpdateIPsForNodeSubnet is called only when IPs are fetched from NMAgent.
-	// We now have IPs to serve IPAM requests. Generate conflist to indicate CNS is ready
-	service.ncSynced = make(chan struct{}) // in case this is called multiple times
+	//encapsulation viloation. Better if this called something equivalent to StartSyncHostNCVersionLoop
 	service.mustGenerateCNIConflistOnce()
 	return nil
 }

cns/restserver/synchostnc.go

@@ -15,7 +15,7 @@ import (
 	"github.com/pkg/errors"
 )
 
-//TODO make this file a sub pacakge?
+// TODO: make this file a sub pacakge?
 
 func (service *HTTPRestService) StartSyncHostNCVersionLoop(ctx context.Context, cnsconfig configuration.CNSConfig) error {
 	if !service.ncSyncLoop.CompareAndSwap(false, true) {

cns/service/main.go

@@ -1121,7 +1121,7 @@ func main() {
 	// Wait for NC sync to complete before marking service as ready.
 	httpRemoteRestService.WaitForConfList(rootCtx)
 	// mark the service as "ready"
-	close(readyCh) // This will not block, even if rootCtx is canceled.
+	close(readyCh)
 	// block until process exiting
 	<-rootCtx.Done()