very basic post

Author: pjohnst5

cns/restserver/api.go

@@ -1348,8 +1348,7 @@ func (service *HTTPRestService) ibDevicesHandler(w http.ResponseWriter, r *http.
 
 	switch r.Method {
 	case http.MethodPost:
-		// TODO: Implement POST
-		http.Error(w, "POST method not yet implemented", http.StatusNotImplemented)
+		service.assignIBDevicesToPod(w, r)
 	case http.MethodGet:
 		// TODO: Implement GET
 		http.Error(w, "GET method not yet implemented", http.StatusNotImplemented)

cns/restserver/api_test.go

@@ -10,6 +10,7 @@ import (
 	"encoding/xml"
 	"fmt"
 	"io"
+	"net"
 	"net/http"
 	"net/http/httptest"
 	"net/url"
@@ -1916,6 +1917,38 @@ func TestGetVMUniqueIDFailed(t *testing.T) {
 	assert.Equal(t, types.UnexpectedError, vmIDResp.Response.ReturnCode)
 }
 
+func TestIBDevices(t *testing.T) {
+	var (
+		err          error
+		req          *http.Request
+		ibDevicesReq cns.AssignIBDevicesToPodRequest
+		body         bytes.Buffer
+	)
+
+	ibDevicesReq.PodName = "testpod"
+	ibDevicesReq.PodNamespace = "testpodnamespace"
+	ibDevicesReq.IBMACAddresses = []net.HardwareAddr{
+		{0x00, 0x1A, 0x2B, 0x3C, 0x4D, 0x5E},
+		{0xDE, 0xAD, 0xBE, 0xEF, 0x00, 0x01},
+	}
+
+	json.NewEncoder(&body).Encode(ibDevicesReq)
+	req, err = http.NewRequest(http.MethodPost, cns.IBDevicesPath, &body)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	w := httptest.NewRecorder()
+	mux.ServeHTTP(w, req)
+	var ibDevicesResponse cns.AssignIBDevicesToPodResponse
+
+	if err = decodeResponse(w, &ibDevicesResponse); err != nil {
+		t.Errorf("AssignIBDevicesToPod failed with response %+v and error %v", ibDevicesResponse, err)
+	}
+
+	fmt.Printf("Raw response: %+v", w.Body)
+}
+
 // IGNORE TEST AS IT IS FAILING. TODO:- Fix it https://msazure.visualstudio.com/One/_workitems/edit/7720083
 // // Tests CreateNetwork functionality.
 

cns/restserver/ibdevices.go

@@ -0,0 +1,57 @@
+package restserver
+
+import (
+	"fmt"
+	"net/http"
+
+	"github.com/Azure/azure-container-networking/cns"
+	"github.com/Azure/azure-container-networking/cns/logger"
+	"github.com/Azure/azure-container-networking/cns/types"
+	"github.com/Azure/azure-container-networking/common"
+)
+
+// assignIBDevicesToPod handles POST requests to assign IB devices to a pod
+func (service *HTTPRestService) assignIBDevicesToPod(w http.ResponseWriter, r *http.Request) {
+	opName := "assignIBDevicesToPod"
+	var req cns.AssignIBDevicesToPodRequest
+	var response cns.AssignIBDevicesToPodResponse
+
+	// Decode the request
+	err := common.Decode(w, r, &req)
+	logger.Request(service.Name, &req, err)
+	if err != nil {
+		return
+	}
+
+	// Validate the request
+	if err := validateAssignIBDevicesRequest(req); err != nil {
+		response.Message = fmt.Sprintf("Invalid request: %v", err)
+		w.WriteHeader(http.StatusBadRequest)
+		err = common.Encode(w, &response)
+		logger.Response(opName, response, types.InvalidRequest, err)
+		return
+	}
+
+	// TODO: Check that the pod exists
+	// TODO: Check that the IB devices are "unprogrammed" (i.e. available)
+	// TODO: Create MTPNC with IB devices in spec (and update cache)
+
+	// Report back a successful assignment
+	response.Message = fmt.Sprintf("Successfully assigned %d IB devices to pod %s/%s",
+		len(req.IBMACAddresses), req.PodNamespace, req.PodName)
+
+	w.WriteHeader(http.StatusOK)
+	err = common.Encode(w, &response)
+	logger.Response(opName, response, types.Success, err)
+}
+
+func validateAssignIBDevicesRequest(req cns.AssignIBDevicesToPodRequest) error {
+	if req.PodName == "" || req.PodNamespace == "" {
+		return fmt.Errorf("pod name and namespace are required")
+	}
+	if len(req.IBMACAddresses) == 0 {
+		return fmt.Errorf("at least one IB MAC address is required")
+	}
+	// TODO Make sure that the given MAC is valid too
+	return nil
+}