Fix wait timeout issue for getting file lock (#193)

tamilmani1989 · sharmasushant · commit 700a25714a13 · 2018-07-11T14:52:23.000-07:00
* fixed a potential timeout issue for getting file lock
diff --git a/store/json.go b/store/json.go
@@ -24,7 +24,7 @@ const (
 	lockMaxRetries = 20
 
 	// Delay between lock retries.
-	lockRetryDelay = 100 * time.Millisecond
+	lockRetryDelayInMilliseconds = 100
 )
 
 // jsonFileStore is an implementation of KeyValueStore using a local JSON file.
@@ -157,7 +157,7 @@ func (kvs *jsonFileStore) Lock(block bool) error {
 			return ErrStoreLocked
 		}
 
-		time.Sleep(lockRetryDelay)
+		time.Sleep(time.Duration(lockRetryDelayInMilliseconds) * time.Millisecond)
 	}
 
 	// Write the process ID for easy identification.

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ const (`
`24`	`24`	`lockMaxRetries = 20`
`25`	`25`
`26`	`26`	`// Delay between lock retries.`
`27`		`- lockRetryDelay = 100 * time.Millisecond`
	`27`	`+ lockRetryDelayInMilliseconds = 100`
`28`	`28`	`)`
`29`	`29`
`30`	`30`	`// jsonFileStore is an implementation of KeyValueStore using a local JSON file.`
`@@ -157,7 +157,7 @@ func (kvs *jsonFileStore) Lock(block bool) error {`
`157`	`157`	`return ErrStoreLocked`
`158`	`158`	`}`
`159`	`159`
`160`		`- time.Sleep(lockRetryDelay)`
	`160`	`+ time.Sleep(time.Duration(lockRetryDelayInMilliseconds) * time.Millisecond)`
`161`	`161`	`}`
`162`	`162`
`163`	`163`	`// Write the process ID for easy identification.`