fix: correctly return an error for non http 200 response from nmagent (#1333)

rbtr · web-flow · commit 704ba1adf571 · 2022-04-18T21:50:03.000Z
Signed-off-by: Evan Baker &lt;rbtr@users.noreply.github.com&gt;
diff --git a/cns/nmagent/client.go b/cns/nmagent/client.go
@@ -255,7 +255,7 @@ func (c *Client) GetNCVersionList(ctx context.Context) (*NetworkContainerListRes
 	logger.Printf("[NMAgentClient][Response] GetNcVersionListWithOutToken response: %s, latency is %d", string(b), time.Since(now).Milliseconds())
 
 	if resp.StatusCode != http.StatusOK {
-		return nil, errors.Wrap(err, "failed to GetNCVersionList")
+		return nil, errors.Errorf("failed to GetNCVersionList with status %d", resp.StatusCode)
 	}
 
 	var response NetworkContainerListResponse

Original file line number	Diff line number	Diff line change
`@@ -255,7 +255,7 @@ func (c Client) GetNCVersionList(ctx context.Context) (NetworkContainerListRes`
`255`	`255`	`logger.Printf("[NMAgentClient][Response] GetNcVersionListWithOutToken response: %s, latency is %d", string(b), time.Since(now).Milliseconds())`
`256`	`256`
`257`	`257`	`if resp.StatusCode != http.StatusOK {`
`258`		`- return nil, errors.Wrap(err, "failed to GetNCVersionList")`
	`258`	`+ return nil, errors.Errorf("failed to GetNCVersionList with status %d", resp.StatusCode)`
`259`	`259`	`}`
`260`	`260`
`261`	`261`	`var response NetworkContainerListResponse`