Skip to content

Commit 76ae491

Browse files
author
sivakami
committed
fix resource group parameter.
1 parent 4e465cc commit 76ae491

File tree

2 files changed

+26
-19
lines changed

2 files changed

+26
-19
lines changed

.pipelines/swiftv2-long-running/pipeline.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,12 @@ parameters:
2222
default: "centraluseuap"
2323

2424
- name: resourceGroupName
25-
displayName: "Resource Group Name (IMPORTANT: Change this when creating new setup to avoid collisions!)"
25+
displayName: "Resource Group Name (Leave empty to auto-generate: sv2-long-run-<location>. Or provide custom name for parallel setups)"
2626
type: string
27-
default: "sv2-long-run-${{ parameters.location }}"
27+
default: ""
2828

2929
- name: runSetupStages
30-
displayName: "Create new setup(AKS + Network) - WARNING: Set resourceGroupName to unique value if creating new setup!"
30+
displayName: "Create new setup(AKS + Network) - WARNING: Use unique resourceGroupName for parallel setups!"
3131
type: boolean
3232
default: false
3333

.pipelines/swiftv2-long-running/template/long-running-pipeline-template.yaml

Lines changed: 23 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,13 @@ parameters:
1515
type: boolean
1616
default: false
1717

18+
variables:
19+
- name: rgName
20+
${{ if ne(parameters.resourceGroupName, '') }}:
21+
value: ${{ parameters.resourceGroupName }}
22+
${{ else }}:
23+
value: sv2-long-run-${{ parameters.location }}
24+
1825
stages:
1926
# =================================================================
2027
# Stage 1: AKS Cluster and Networking Setup (Conditional)
@@ -41,9 +48,9 @@ stages:
4148
inlineScript: |
4249
echo "Org: $SYSTEM_COLLECTIONURI"
4350
echo "Project: $SYSTEM_TEAMPROJECT"
44-
echo "==> Creating resource group ${{ parameters.resourceGroupName }} in ${{ parameters.location }}"
51+
echo "==> Creating resource group $(rgName) in ${{ parameters.location }}"
4552
az group create \
46-
--name "${{ parameters.resourceGroupName }}" \
53+
--name "$(rgName)" \
4754
--location "${{ parameters.location }}" \
4855
--tags SkipAutoDeleteTill=2032-12-31 \
4956
--subscription "${{ parameters.subscriptionId }}"
@@ -69,7 +76,7 @@ stages:
6976
arguments: >
7077
${{ parameters.subscriptionId }}
7178
${{ parameters.location }}
72-
${{ parameters.resourceGroupName }}
79+
$(rgName)
7380
${{ parameters.vmSkuDefault }}
7481
${{ parameters.vmSkuHighNIC }}
7582
@@ -96,7 +103,7 @@ stages:
96103
arguments: >
97104
${{ parameters.subscriptionId }}
98105
${{ parameters.location }}
99-
${{ parameters.resourceGroupName }}
106+
$(rgName)
100107
$(Build.BuildId)
101108
102109
# Task 2: Create Peerings
@@ -108,7 +115,7 @@ stages:
108115
scriptLocation: scriptPath
109116
scriptPath: ".pipelines/swiftv2-long-running/scripts/create_peerings.sh"
110117
arguments: >
111-
${{ parameters.resourceGroupName }}
118+
$(rgName)
112119
113120
# Task 3: Create Storage Accounts
114121
- task: AzureCLI@2
@@ -122,7 +129,7 @@ stages:
122129
arguments: >
123130
${{ parameters.subscriptionId }}
124131
${{ parameters.location }}
125-
${{ parameters.resourceGroupName }}
132+
$(rgName)
126133
127134
# Task 4: Create NSG
128135
- task: AzureCLI@2
@@ -134,7 +141,7 @@ stages:
134141
scriptPath: ".pipelines/swiftv2-long-running/scripts/create_nsg.sh"
135142
arguments: >
136143
${{ parameters.subscriptionId }}
137-
${{ parameters.resourceGroupName }}
144+
$(rgName)
138145
${{ parameters.location }}
139146
140147
# Task 5: Create Private Endpoint
@@ -148,7 +155,7 @@ stages:
148155
arguments: >
149156
${{ parameters.subscriptionId }}
150157
${{ parameters.location }}
151-
${{ parameters.resourceGroupName }}
158+
$(rgName)
152159
$(CreateStorageAccounts.StorageAccount1)
153160
# =================================================================
154161
# Stage 2: Datapath Tests
@@ -192,15 +199,15 @@ stages:
192199
193200
echo "==> Setting up kubeconfig for cluster aks-1"
194201
az aks get-credentials \
195-
--resource-group ${{ parameters.resourceGroupName }} \
202+
--resource-group $(rgName) \
196203
--name aks-1 \
197204
--file /tmp/aks-1.kubeconfig \
198205
--overwrite-existing \
199206
--admin
200207
201208
echo "==> Setting up kubeconfig for cluster aks-2"
202209
az aks get-credentials \
203-
--resource-group ${{ parameters.resourceGroupName }} \
210+
--resource-group $(rgName) \
204211
--name aks-2 \
205212
--file /tmp/aks-2.kubeconfig \
206213
--overwrite-existing \
@@ -213,8 +220,8 @@ stages:
213220
kubectl --kubeconfig /tmp/aks-2.kubeconfig get nodes
214221
215222
echo "==> Creating test resources (8 scenarios)"
216-
export RG=${{ parameters.resourceGroupName }}
217-
export BUILD_ID=${{ parameters.resourceGroupName }}
223+
export RG=$(rgName)
224+
export BUILD_ID=$(rgName)
218225
ginkgo -v -trace --timeout=1h ./test/integration/swiftv2/longRunningCluster --focus="Datapath Create"
219226
220227
- script: |
@@ -258,22 +265,22 @@ stages:
258265
259266
echo "==> Setting up kubeconfig for cluster aks-1"
260267
az aks get-credentials \
261-
--resource-group ${{ parameters.resourceGroupName }} \
268+
--resource-group $(rgName) \
262269
--name aks-1 \
263270
--file /tmp/aks-1.kubeconfig \
264271
--overwrite-existing \
265272
--admin
266273
267274
echo "==> Setting up kubeconfig for cluster aks-2"
268275
az aks get-credentials \
269-
--resource-group ${{ parameters.resourceGroupName }} \
276+
--resource-group $(rgName) \
270277
--name aks-2 \
271278
--file /tmp/aks-2.kubeconfig \
272279
--overwrite-existing \
273280
--admin
274281
275282
echo "==> Deleting test resources (8 scenarios)"
276-
export RG=${{ parameters.resourceGroupName }}
277-
export BUILD_ID=${{ parameters.resourceGroupName }}
283+
export RG=$(rgName)
284+
export BUILD_ID=$(rgName)
278285
ginkgo -v -trace --timeout=1h ./test/integration/swiftv2/longRunningCluster --focus="Datapath Delete"
279286

0 commit comments

Comments
 (0)