feat: do not stop deletion on missing hns id

santhoshmprabhu · santhoshmprabhu · commit 7bd2f6d34774 · 2025-03-21T15:04:13.000-07:00
diff --git a/network/endpoint_windows.go b/network/endpoint_windows.go
@@ -531,7 +531,7 @@ func (nw *network) deleteEndpointImpl(_ netlink.NetlinkInterface, _ platform.Exe
 
 	if ep.HnsId == "" {
 		logger.Error("No HNS id found. Skip endpoint deletion", zap.Any("nicType", ep.NICType), zap.String("containerId", ep.ContainerID))
-		return fmt.Errorf("No HNS id found. Skip endpoint deletion for nicType %v, containerID %s", ep.NICType, ep.ContainerID) //nolint
+		return nil
 	}
 
 	if useHnsV2, err := UseHnsV2(ep.NetNs); useHnsV2 {

Original file line number	Diff line number	Diff line change
`@@ -531,7 +531,7 @@ func (nw *network) deleteEndpointImpl(_ netlink.NetlinkInterface, _ platform.Exe`
`531`	`531`
`532`	`532`	`if ep.HnsId == "" {`
`533`	`533`	`logger.Error("No HNS id found. Skip endpoint deletion", zap.Any("nicType", ep.NICType), zap.String("containerId", ep.ContainerID))`
`534`		`- return fmt.Errorf("No HNS id found. Skip endpoint deletion for nicType %v, containerID %s", ep.NICType, ep.ContainerID) //nolint`
	`534`	`+ return nil`
`535`	`535`	`}`
`536`	`536`
`537`	`537`	`if useHnsV2, err := UseHnsV2(ep.NetNs); useHnsV2 {`