log: [NPM] init telemetry before dataplane (#3316)

huntergregory · web-flow · commit 7da20f56b93d · 2025-01-07T02:23:20.000Z
Signed-off-by: Hunter Gregory &lt;42728408+huntergregory@users.noreply.github.com&gt;
diff --git a/npm/cmd/start.go b/npm/cmd/start.go
@@ -131,7 +131,11 @@ func start(config npmconfig.Config, flags npmconfig.Flags) error {
 			}),
 		)
 	}
-	k8sServerVersion := k8sServerVersion(clientset)
+
+	err = metrics.CreateTelemetryHandle(config.NPMVersion(), version, npm.GetAIMetadata())
+	if err != nil {
+		klog.Infof("CreateTelemetryHandle failed with error %v. AITelemetry is not initialized.", err)
+	}
 
 	var dp dataplane.GenericDataplane
 	stopChannel := wait.NeverStop
@@ -197,11 +201,9 @@ func start(config npmconfig.Config, flags npmconfig.Flags) error {
 		}
 		dp.RunPeriodicTasks()
 	}
+
+	k8sServerVersion := k8sServerVersion(clientset)
 	npMgr := npm.NewNetworkPolicyManager(config, factory, podFactory, dp, exec.New(), version, k8sServerVersion)
-	err = metrics.CreateTelemetryHandle(config.NPMVersion(), version, npm.GetAIMetadata())
-	if err != nil {
-		klog.Infof("CreateTelemetryHandle failed with error %v. AITelemetry is not initialized.", err)
-	}
 
 	go restserver.NPMRestServerListenAndServe(config, npMgr)
 

Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,11 @@ func start(config npmconfig.Config, flags npmconfig.Flags) error {`
`131`	`131`	`}),`
`132`	`132`	`)`
`133`	`133`	`}`
`134`		`- k8sServerVersion := k8sServerVersion(clientset)`
	`134`	`+`
	`135`	`+ err = metrics.CreateTelemetryHandle(config.NPMVersion(), version, npm.GetAIMetadata())`
	`136`	`+ if err != nil {`
	`137`	`+ klog.Infof("CreateTelemetryHandle failed with error %v. AITelemetry is not initialized.", err)`
	`138`	`+ }`
`135`	`139`
`136`	`140`	`var dp dataplane.GenericDataplane`
`137`	`141`	`stopChannel := wait.NeverStop`
`@@ -197,11 +201,9 @@ func start(config npmconfig.Config, flags npmconfig.Flags) error {`
`197`	`201`	`}`
`198`	`202`	`dp.RunPeriodicTasks()`
`199`	`203`	`}`
	`204`	`+`
	`205`	`+ k8sServerVersion := k8sServerVersion(clientset)`
`200`	`206`	`npMgr := npm.NewNetworkPolicyManager(config, factory, podFactory, dp, exec.New(), version, k8sServerVersion)`
`201`		`- err = metrics.CreateTelemetryHandle(config.NPMVersion(), version, npm.GetAIMetadata())`
`202`		`- if err != nil {`
`203`		`- klog.Infof("CreateTelemetryHandle failed with error %v. AITelemetry is not initialized.", err)`
`204`		`- }`
`205`	`207`
`206`	`208`	`go restserver.NPMRestServerListenAndServe(config, npMgr)`
`207`	`209`