chore: address comments

Author: santhoshmprabhu

cns/restserver/nodesubnet.go

@@ -29,8 +29,9 @@ func (service *HTTPRestService) UpdateIPsForNodeSubnet(secondaryIPs []netip.Addr
 
 	logger.Debugf("IP change processed successfully")
 
-	// saved NC successfully, generate conflist to indicate CNS is ready
-	go service.MustGenerateCNIConflistOnce()
+	// saved NC successfully. UpdateIPsForNodeSubnet is called only when IPs are fetched from NMAgent.
+	// We now have IPs to serve IPAM requests. Generate conflist to indicate CNS is ready
+	service.MustGenerateCNIConflistOnce()
 	return nil
 }
 

cns/service/main.go

@@ -1046,6 +1046,8 @@ func main() {
 	}
 
 	if config.ChannelMode == cns.AzureHost {
+		// at this point, rest service is running, and any pending async deletes have been submitted to the rest
+		// service. We can now start serving new requests.
 		httpRemoteRestService.StartNodeSubnet(rootCtx)
 	}