updated code to fix lint error

Author: Riya

cns/restserver/internalapi.go

@@ -23,7 +23,9 @@ import (
 	"github.com/Azure/azure-container-networking/cns/types"
 	"github.com/Azure/azure-container-networking/common"
 	"github.com/Azure/azure-container-networking/crd/nodenetworkconfig/api/v1alpha"
+	"github.com/labstack/gommon/log"
 	"github.com/pkg/errors"
+	"go.uber.org/zap"
 )
 
 const (
@@ -640,7 +642,7 @@ func (service *HTTPRestService) CreateOrUpdateNetworkContainerInternal(req *cns.
 				req.IPConfiguration.IPSubnet.PrefixLength)
 			// delete the existing azure-cns file
 			if err := os.Remove(cnsStateFilePath); err != nil && !os.IsNotExist(err) {
-				logger.Errorf("[Azure CNS] Error deleting azure-cns state file: %v", err)
+				log.Error("Error deleting azure-cns state file", zap.Error(err))
 			}
 
 			// panic (this will force azure-cns daemonset to restart and pick up the new state with updated nnc)

cns/restserver/internalapi_test.go

@@ -97,7 +97,7 @@ func TestReconcileNCStatePrimaryIPChangeShouldFail(t *testing.T) {
 
 	// Create dummy CNS state file
 	stateFile := "/var/lib/azure-network/azure-cns.json"
-	_ = os.WriteFile(stateFile, []byte("dummy"), 0644)
+	_ = os.WriteFile(stateFile, []byte("dummy"), 0600)
 	defer os.Remove(stateFile)
 
 	defer func() {
@@ -1701,13 +1701,13 @@ func TestCreateOrUpdateNCInternal_PrimaryCAMismatchShouldPanicAndDeleteStateFile
 	// Step 1: Create initial NC with PrimaryCA "10.0.0.5/24"
 	secondaryIPConfigs := make(map[string]cns.SecondaryIPConfig)
 	ipaddress := "10.0.0.6"
-	secIpConfig := newSecondaryIPConfig(ipaddress, -1)
-	ipId := uuid.New()
-	secondaryIPConfigs[ipId.String()] = secIpConfig
+	secIPConfig := newSecondaryIPConfig(ipaddress, -1)
+	ipID := uuid.New()
+	secondaryIPConfigs[ipID.String()] = secIPConfig
 
-	ncId := "test-nc"
+	ncID := "test-nc"
 	ncVersion := "-1"
-	req := generateNetworkContainerRequest(secondaryIPConfigs, ncId, ncVersion)
+	req := generateNetworkContainerRequest(secondaryIPConfigs, ncID, ncVersion)
 	req.IPConfiguration.IPSubnet.IPAddress = "10.0.0.5"
 	req.IPConfiguration.IPSubnet.PrefixLength = 24
 	returnCode := svc.CreateOrUpdateNetworkContainerInternal(req)
@@ -1717,13 +1717,13 @@ func TestCreateOrUpdateNCInternal_PrimaryCAMismatchShouldPanicAndDeleteStateFile
 	validateNetworkRequest(t, *req)
 
 	// Step 2: Prepare a request with a different PrimaryCA
-	reqMismatch := generateNetworkContainerRequest(secondaryIPConfigs, ncId, ncVersion)
+	reqMismatch := generateNetworkContainerRequest(secondaryIPConfigs, ncID, ncVersion)
 	reqMismatch.IPConfiguration.IPSubnet.IPAddress = "10.0.0.7" // different IP
 	reqMismatch.IPConfiguration.IPSubnet.PrefixLength = 24
 
 	// Step 3: Create dummy CNS state file
 	stateFile := "/var/lib/azure-network/azure-cns.json"
-	_ = os.WriteFile(stateFile, []byte("dummy"), 0644)
+	_ = os.WriteFile(stateFile, []byte("dummy"), 0600)
 	defer os.Remove(stateFile)
 
 	defer func() {