refactored get default deny acl function

Author: rejain789

cns/middlewares/k8sSwiftV2.go

@@ -82,11 +82,14 @@ func (k *K8sSWIFTv2Middleware) IPConfigsRequestHandlerWrapper(defaultHandler, fa
 		// Set routes for the pod
 		for i := range ipConfigsResp.PodIPInfo {
 			ipInfo := &ipConfigsResp.PodIPInfo[i]
+			if defaultDenyACLbool {
+				err := addDefaultDenyACL(ipInfo)
+				if err != nil {
+					errors.Wrapf(err, "failed to add default deny acl's for pod %s", podInfo.Name())
+				}
+			}
 			// Backend nics doesn't need routes to be set
 			if ipInfo.NICType != cns.BackendNIC {
-				if defaultDenyACLbool {
-					k.addDefaultDenyAcl(ipInfo)
-				}
 				err = k.setRoutes(ipInfo)
 				if err != nil {
 					return &cns.IPConfigsResponse{

cns/middlewares/k8sSwiftV2_linux.go

@@ -104,6 +104,6 @@ func (k *K8sSWIFTv2Middleware) assignSubnetPrefixLengthFields(_ *cns.PodIpInfo,
 
 func (k *K8sSWIFTv2Middleware) addDefaultRoute(*cns.PodIpInfo, string) {}
 
-func (k *K8sSWIFTv2Middleware) addDefaultDenyAcl(podIPInfo *cns.PodIpInfo) error {
+func addDefaultDenyACL(podIPInfo *cns.PodIpInfo) error {
 	return nil
 }

cns/middlewares/k8sSwiftV2_windows.go

@@ -64,7 +64,7 @@ func (k *K8sSWIFTv2Middleware) addDefaultRoute(podIPInfo *cns.PodIpInfo, gwIP st
 	podIPInfo.Routes = append(podIPInfo.Routes, route)
 }
 
-func (k *K8sSWIFTv2Middleware) addDefaultDenyAcl(podIPInfo *cns.PodIpInfo) error {
+func addDefaultDenyACL(podIPInfo *cns.PodIpInfo) error {
 	additionalArgs := []cni.KVPair{
 		{
 			Name:  "EndpointPolicy",
@@ -75,7 +75,7 @@ func (k *K8sSWIFTv2Middleware) addDefaultDenyAcl(podIPInfo *cns.PodIpInfo) error
 			Value: getDefaultDenyACLPolicy(hcn.DirectionTypeIn),
 		},
 	}
-	podIPInfo.DefaultDenyACL = append(podIPInfo.DefaultDenyACL, additionalArgs...) //insert acl here
+	podIPInfo.DefaultDenyACL = append(podIPInfo.DefaultDenyACL, additionalArgs...)
 	return nil
 }