remove unused code

Author: NihaNallappagari

cns/restserver/internalapi.go

@@ -195,16 +195,6 @@ var errNonExistentContainerStatus = errors.New("nonExistantContainerstatus")
 // all NCs and update the CNS state accordingly. This function returns the the total number of NCs on this VM that have been programmed to
 // some version, NOT the number of NCs that are up-to-date.
 func (service *HTTPRestService) syncHostNCVersion(ctx context.Context, channelMode string) (int, error) {
-	// will remove it later
-	// hasVNETBlockNC1 := service.isPrefixonNicSwiftV2()
-	// logger.Printf("winDebug: syncHostNCVersion hasVNETBlockNC1 %v", hasVNETBlockNC1)
-	// if runtime.GOOS == "windows" {
-	// 	logger.Printf("winDebug: before setPrefixOnNICRegistry in syncHostNCVersion")
-	// 	err := service.setPrefixOnNICRegistry(true, "aa:bb:cc:dd:ee:ff")
-	// 	if err != nil {
-	// 		logger.Debugf("failed to add PrefixOnNic keys to Windows registry: %w", err)
-	// 	}
-	// }
 	outdatedNCs := map[string]struct{}{}
 	programmedNCs := map[string]struct{}{}
 	for idx := range service.state.ContainerStatus {
@@ -739,13 +729,12 @@ func (service *HTTPRestService) getIMDSNCs(ctx context.Context) (map[string]stri
 	return ncs, nil
 }
 
-// isPrefixonNicSwiftV2 checks if any NC in the container status should use SwiftV2 PrefixOnNic
-// Uses the SwiftV2PrefixOnNic field which captures the condition: isSwiftV2 && nc.Type == VNETBlock
+// Check whether NC is SwiftV2 NIC associated NC and prefix on nic is enabled
 func (service *HTTPRestService) isPrefixonNicSwiftV2() bool {
 	for _, containerStatus := range service.state.ContainerStatus {
 		req := containerStatus.CreateNetworkContainerRequest
 
-		// Check if this NC is SwiftV2 PrefixOnNic setting
+		// 
 		if req.SwiftV2PrefixOnNic {
 			return true
 		}

cns/restserver/internalapi_linux.go

@@ -183,11 +183,10 @@ func (service *HTTPRestService) setVFForAccelnetNICs() error {
 }
 
 func (service *HTTPRestService) setPrefixOnNICRegistry(enabled bool, infraNicMacAddress string) error {
+	    // Assigning parameters to '_' to avoid unused parameter linting errors.
+    // These parameters are only used in the Windows implementation.
+    _ = enabled
+    _ = infraNicMacAddress
 	logger.Printf("[setPrefixOnNicEnabled winDebug] No-op on Linux platform")
 	return nil
-}
-
-func (service *HTTPRestService) getPrefixOnNicEnabled() (bool, error) {
-	logger.Printf(" winDebug getPrefixOnNicEnabled is a no-op on non-Windows platforms")
-	return false, nil // Add this missing return statement
 }

cns/restserver/internalapi_windows.go

@@ -147,25 +147,5 @@ func (service *HTTPRestService) setRegistryValue(registryPath, keyName string, v
 	}
 
 	logger.Printf("[setRegistryValue] Set %s\\%s = %v", registryPath, keyName, value) 
-	// have to remove this log later
-	// test, _ := service.getPrefixOnNicEnabled()
-	// logger.Printf("winDebug: setRegistryValue getPrefixOnNicEnabled %v", test)
 	return nil
-}
-
-// for testing purpose, will remove it later
-
-// func (service *HTTPRestService) getPrefixOnNicEnabled() (bool, error) {
-// 	key, err := registry.OpenKey(registry.LOCAL_MACHINE, prefixOnNicRegistryPath, registry.QUERY_VALUE)
-// 	if err != nil {
-// 		return false, nil // Key doesn't exist, default to false
-// 	}
-// 	defer key.Close()
-
-// 	value, _, err := key.GetIntegerValue("enabled")
-// 	if err != nil {
-// 		return false, nil // Value doesn't exist, default to false
-// 	}
-
-// 	return value == 1, nil
-// }
+}