fix: make linter happy

Author: santhoshmprabhu

cns/restserver/nodesubnet.go

@@ -26,10 +26,10 @@ func (service *HTTPRestService) UpdateIPsForNodeSubnet(secondaryIPs []netip.Addr
 	if code != types.Success {
 		logger.Debugf("Error in processing IP change")
 		return errors.Errorf("failed to save fetched ips. code: %d, message %s", code, msg)
-	} else {
-		logger.Debugf("IP change processed successfully")
 	}
 
+	logger.Debugf("IP change processed successfully")
+
 	// saved NC successfully, generate conflist to indicate CNS is ready
 	go service.MustGenerateCNIConflistOnce()
 	return nil

cns/restserver/restserver.go

@@ -19,7 +19,6 @@ import (
 	"github.com/Azure/azure-container-networking/cns/types/bounded"
 	"github.com/Azure/azure-container-networking/cns/wireserver"
 	acn "github.com/Azure/azure-container-networking/common"
-	"github.com/Azure/azure-container-networking/nmagent"
 	nma "github.com/Azure/azure-container-networking/nmagent"
 	"github.com/Azure/azure-container-networking/store"
 	"github.com/pkg/errors"
@@ -42,7 +41,7 @@ type nmagentClient interface {
 	SupportedAPIs(context.Context) ([]string, error)
 	GetNCVersionList(context.Context) (nma.NCVersionList, error)
 	GetHomeAz(context.Context) (nma.AzResponse, error)
-	GetInterfaceIPInfo(ctx context.Context) (nmagent.Interfaces, error)
+	GetInterfaceIPInfo(ctx context.Context) (nma.Interfaces, error)
 }
 
 type wireserverProxy interface {

cns/service/main.go

@@ -883,13 +883,18 @@ func main() {
 			cns.GlobalPodInfoScheme = cns.InfraIDPodInfoScheme
 		}
 
-		podInfoByIPProvider, err := getPodInfoByIPProvider(rootCtx, cnsconfig, httpRemoteRestService, nil, "")
+		var podInfoByIPProvider cns.PodInfoByIPProvider
+		podInfoByIPProvider, err = getPodInfoByIPProvider(rootCtx, cnsconfig, httpRemoteRestService, nil, "")
 		if err != nil {
 			logger.Errorf("[Azure CNS] Failed to get PodInfoByIPProvider: %v", err)
 			return
 		}
 
-		httpRemoteRestService.InitializeNodeSubnet(rootCtx, podInfoByIPProvider)
+		err = httpRemoteRestService.InitializeNodeSubnet(rootCtx, podInfoByIPProvider)
+		if err != nil {
+			logger.Errorf("[Azure CNS] Failed to initialize node subnet: %v", err)
+			return
+		}
 	}
 
 	// Initialize multi-tenant controller if the CNS is running in MultiTenantCRD mode.