Addressed feedback

Author: ninzavivek

cns/api.go

@@ -18,7 +18,7 @@ const (
 	GetIPAddressUtilizationPath = "/network/ip/utilization"
 	GetUnhealthyIPAddressesPath = "/network/ipaddresses/unhealthy"
 	GetHealthReportPath         = "/network/health"
-	NumberOfCPUCoresPath        = "/network/hostcpucores"
+	NumberOfCPUCoresPath        = "/hostcpucores"
 	V1Prefix                    = "/v0.1"
 	V2Prefix                    = "/v0.2"
 )
@@ -140,7 +140,7 @@ type Response struct {
 	Message    string
 }
 
-// getNumberOfCPUCores describes reponse that returns the host local IP Address.
+// getNumberOfCPUCores describes reponse that returns num of cpu cores present on host.
 type NumOfCPUCoresResponse struct {
 	Response      Response
 	NumOfCPUCores int

cns/restserver/restserver.go

@@ -1580,22 +1580,22 @@ func (service *HTTPRestService) getNetPluginDetails() *networkcontainers.NetPlug
 // Retrieves the number of logic processors on a node. It will be primarily
 // used to enforce per VM delegated NIC limit by DNC.
 func (service *HTTPRestService) getNumberOfCPUCores(w http.ResponseWriter, r *http.Request) {
-	log.Printf("[Azure CNS] getNumberOfCPUCores")
+	log.Printf("[Azure-CNS] getNumberOfCPUCores")
 	log.Request(service.Name, "getNumberOfCPUCores", nil)
 
-	var num = 0
-	var returnCode = 0
-	var errmsg string
+	var num int
+	var returnCode int
+	var errMsg string
 
 	switch r.Method {
 	case "GET":
 		num = runtime.NumCPU()
 	default:
-		errmsg = "[Azure-CNS] getNumberOfCPUCores API expects a GET."
+		errMsg = "[Azure-CNS] getNumberOfCPUCores API expects a GET."
 		returnCode = UnsupportedVerb
 	}
 
-	resp := cns.Response{ReturnCode: returnCode, Message: errmsg}
+	resp := cns.Response{ReturnCode: returnCode, Message: errMsg}
 	numOfCPUCoresResp := cns.NumOfCPUCoresResponse{
 		Response:      resp,
 		NumOfCPUCores: num,

cns/restserver/restserver_test.go

@@ -693,12 +693,15 @@ func TestGetInterfaceForNetworkContainer(t *testing.T) {
 func TestGetNumOfCPUCores(t *testing.T) {
 	fmt.Println("Test: getNumberOfCPUCores")
 
-	req, err := http.NewRequest(http.MethodGet, cns.NumberOfCPUCoresPath, nil)
+	var err error
+	var req *http.Request
+	req, err = http.NewRequest(http.MethodGet, cns.NumberOfCPUCoresPath, nil)
 	if err != nil {
 		t.Fatal(err)
 	}
 
-	w := httptest.NewRecorder()
+	var w *httptest.ResponseRecorder
+	w = httptest.NewRecorder()
 	mux.ServeHTTP(w, req)
 	var numOfCoresResponse cns.NumOfCPUCoresResponse