fixed if else logic

rejain789 · rejain789 · commit af8d266cd186 · 2025-11-05T22:01:35.000Z
diff --git a/npm/pkg/dataplane/policies/policy_windows.go b/npm/pkg/dataplane/policies/policy_windows.go
@@ -145,11 +145,11 @@ func (acl *ACLPolicy) convertToAclSettings(aclID string) (*NPMACLPolSettings, er
 			// INGRESS: Remote = Source IPs from policy
 			policySettings.RemoteAddresses = srcListStr
 		}
+	} else {
+		policySettings.LocalAddresses = srcListStr
+		policySettings.RemoteAddresses = dstListStr
 	}
 
-	policySettings.LocalAddresses = srcListStr
-	policySettings.RemoteAddresses = dstListStr
-
 	// Switch ports based on direction
 	policySettings.RemotePorts = ""
 	policySettings.LocalPorts = dstPortStr

Original file line number	Diff line number	Diff line change
`@@ -145,11 +145,11 @@ func (acl ACLPolicy) convertToAclSettings(aclID string) (NPMACLPolSettings, er`
`145`	`145`	`// INGRESS: Remote = Source IPs from policy`
`146`	`146`	`policySettings.RemoteAddresses = srcListStr`
`147`	`147`	`}`
	`148`	`+ } else {`
	`149`	`+ policySettings.LocalAddresses = srcListStr`
	`150`	`+ policySettings.RemoteAddresses = dstListStr`
`148`	`151`	`}`
`149`	`152`
`150`		`- policySettings.LocalAddresses = srcListStr`
`151`		`- policySettings.RemoteAddresses = dstListStr`
`152`		`-`
`153`	`153`	`// Switch ports based on direction`
`154`	`154`	`policySettings.RemotePorts = ""`
`155`	`155`	`policySettings.LocalPorts = dstPortStr`